Sign upLogin

jaroslavtyc/drd-plus-codes

View on GitHub
Star
tests/Codes/Armaments/BodyArmorCodeTest.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid using static access to class '\DrdPlus\Codes\Armaments\BodyArmorCode' in method 'I_can_ask_it_if_is_helm_or_body_armor'.
Open

        $bodyArmorCode = BodyArmorCode::getIt(BodyArmorCode::FULL_PLATE_ARMOR);
Severity: Minor
Found in tests/Codes/Armaments/BodyArmorCodeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php declare(strict_types=1);

namespace DrdPlus\Tests\Codes\Armaments;

use DrdPlus\Codes\Armaments\BodyArmorCode;
Severity: Major
Found in tests/Codes/Armaments/BodyArmorCodeTest.php and 1 other location - About 1 hr to fix
tests/Codes/Armaments/HelmCodeTest.php on lines 1..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The method I_can_get_it_with_default_value is not named in camelCase.
Open

    public function I_can_get_it_with_default_value()
    {
        $sut = $this->findSut();
        self::assertSame(BodyArmorCode::WITHOUT_ARMOR, $sut->getValue(), 'Expected without armor as a default value');
    }
Severity: Minor
Found in tests/Codes/Armaments/BodyArmorCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_it_if_is_helm_or_body_armor is not named in camelCase.
Open

    public function I_can_ask_it_if_is_helm_or_body_armor()
    {
        $bodyArmorCode = BodyArmorCode::getIt(BodyArmorCode::FULL_PLATE_ARMOR);
        self::assertFalse($bodyArmorCode->isHelm());
        self::assertTrue($bodyArmorCode->isBodyArmor());
Severity: Minor
Found in tests/Codes/Armaments/BodyArmorCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status