Sign upLogin

jaroslavtyc/drd-plus-codes

View on GitHub
Star
tests/Codes/Armaments/SlingStoneCodeTest.php

Summary

Maintainability
A
55 mins
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php declare(strict_types=1);

namespace DrdPlus\Tests\Codes\Armaments;

use DrdPlus\Codes\Armaments\SlingStoneCode;
Severity: Major
Found in tests/Codes/Armaments/SlingStoneCodeTest.php and 2 other locations - About 55 mins to fix
tests/Codes/Armaments/ArrowCodeTest.php on lines 1..33
tests/Codes/Armaments/DartCodeTest.php on lines 1..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The method I_can_find_out_if_is_arrow is not named in camelCase.
Open

    public function I_can_find_out_if_is_arrow()
    {
        self::assertFalse(SlingStoneCode::getIt(SlingStoneCode::SLING_STONE_HEAVIER)->isArrow());
    }
Severity: Minor
Found in tests/Codes/Armaments/SlingStoneCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_sling_stone is not named in camelCase.
Open

    public function I_can_find_out_if_is_sling_stone()
    {
        self::assertTrue(SlingStoneCode::getIt(SlingStoneCode::SLING_STONE_HEAVIER)->isSlingStone());
    }
Severity: Minor
Found in tests/Codes/Armaments/SlingStoneCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_dart is not named in camelCase.
Open

    public function I_can_find_out_if_is_dart()
    {
        self::assertFalse(SlingStoneCode::getIt(SlingStoneCode::SLING_STONE_LIGHT)->isDart());
    }
Severity: Minor
Found in tests/Codes/Armaments/SlingStoneCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status