jaroslavtyc/drd-plus-codes

Method All_public_constants_can_be_given_by_getter has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function All_public_constants_can_be_given_by_getter()
    {
        $constants = $this->sutReflection->getConstants();
        self::assertEquals($constants, array_unique($constants));
        asort($constants);

Method I_can_extended_it_by_custom_translatable_code has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function I_can_extended_it_by_custom_translatable_code()
    {
        /** @var TranslatableExtendableCode $sutClass */
        $sutClass = self::getSutClass();
        $translations = $this->sutReflection->getProperty('translations');

Missing class import via use statement (line '123', column '32').

Open

        $reflectionClass = new \ReflectionClass(TranslatableExtendableCode::class);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '88', column '18').

Open

        if ((new \ReflectionClass($sutClass))->isAbstract()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '26', column '36').

Open

        $this->sutReflection = new \ReflectionClass($sutClass);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '35', column '43').

Open

        $translatableExtendableCode = new \ReflectionClass(TranslatableExtendableCode::class);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class '\DrdPlus\Codes\Partials\TranslatableExtendableCode' in method 'It_uses_parent_values_as_default_if_not_overloaded'.

Open

        self::assertSame([], TranslatableExtendableCode::getPossibleValues());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid excessively long variable names like $possibleValuesAndConstantsDifference. Keep variable name length under 20.

Open

        $possibleValuesAndConstantsDifference = array_diff($possibleValues, array_values($constants));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $customValuesReflection. Keep variable name length under 20.

Open

        $customValuesReflection = $reflectionClass->getProperty('customValues');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $translatableExtendableCode. Keep variable name length under 20.

Open

        $translatableExtendableCode = new \ReflectionClass(TranslatableExtendableCode::class);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $customCodeTranslations. Keep variable name length under 20.

Open

        $customCodeTranslations = $translatableExtendableCode->getProperty('customCodeTranslations');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

The method I_can_not_use_invalid_plural_for_translation_of_custom_code is not named in camelCase.

Open

    public function I_can_not_use_invalid_plural_for_translation_of_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\UnknownTranslationPlural::class);
        $this->expectExceptionMessageMatches('~all~');
        /** like @see \DrdPlus\Codes\Armaments\ArrowCode::addNewArrowCode */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method I_can_not_use_empty_string_for_translation_of_custom_code is not named in camelCase.

Open

    public function I_can_not_use_empty_string_for_translation_of_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\InvalidTranslationFormat::class);
        $this->expectExceptionMessageMatches("~''~");
        /** like @see \DrdPlus\Codes\Armaments\ArrowCode::addNewArrowCode */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method It_uses_parent_values_as_default_if_not_overloaded is not named in camelCase.

Open

    public function It_uses_parent_values_as_default_if_not_overloaded()
    {
        self::assertSame([], TranslatableExtendableCode::getPossibleValues());
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method I_can_not_use_non_string_for_translation_of_custom_code is not named in camelCase.

Open

    public function I_can_not_use_non_string_for_translation_of_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\InvalidTranslationFormat::class);
        $this->expectExceptionMessageMatches('~NULL~');
        /** like @see \DrdPlus\Codes\Armaments\ArrowCode::addNewArrowCode */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method Method_to_get_default_values_is_not_public is not named in camelCase.

Open

    public function Method_to_get_default_values_is_not_public()
    {
        $sutClass = self::getSutClass();
        $getDefaultValues = $this->sutReflection->getMethod('getDefaultValues');
        self::assertFalse($getDefaultValues->isPublic(), "Method $sutClass::getDefaultValues is not intended to be public");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method I_can_not_use_invalid_data_format_of_translations_for_custom_code is not named in camelCase.

Open

    public function I_can_not_use_invalid_data_format_of_translations_for_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\InvalidTranslationFormat::class);
        $this->expectExceptionMessageMatches('~this should be array~');
        /** like @see \DrdPlus\Codes\Armaments\ArrowCode::addNewArrowCode */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method I_can_not_use_invalid_language_code_format_for_custom_code is not named in camelCase.

Open

    public function I_can_not_use_invalid_language_code_format_for_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\InvalidLanguageCode::class);
        $this->expectExceptionMessageMatches('~a1~');
        /** @var TranslatableExtendableCode $sutClass */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method I_can_extended_it_by_custom_translatable_code is not named in camelCase.

Open

    public function I_can_extended_it_by_custom_translatable_code()
    {
        /** @var TranslatableExtendableCode $sutClass */
        $sutClass = self::getSutClass();
        $translations = $this->sutReflection->getProperty('translations');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method All_public_constants_can_be_given_by_getter is not named in camelCase.

Open

    public function All_public_constants_can_be_given_by_getter()
    {
        $constants = $this->sutReflection->getConstants();
        self::assertEquals($constants, array_unique($constants));
        asort($constants);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}