Missing class import via use statement (line '26', column '27'). Open
$reflection = new \ReflectionClass(self::getSutClass());- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\DrdPlus\Codes\Theurgist\ProfileCode' in method 'I_can_ask_it_for_gender_and_get_opposite'. Open
$lookMars = ProfileCode::getIt(ProfileCode::LOOK_MARS);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Codes\Theurgist\ProfileCode' in method 'I_can_ask_it_for_gender_and_get_opposite'. Open
self::assertSame(ProfileCode::getIt(ProfileCode::LOOK_VENUS), $lookVenus);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method I_can_get_all_codes_at_once_or_by_same_named_constant is not named in camelCase. Open
public function I_can_get_all_codes_at_once_or_by_same_named_constant()
{
// I can not, because characters ♀ and ♂ can not be part of constant name but we want them in value
self::assertFalse(false);
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_can_ask_it_for_gender_and_get_opposite is not named in camelCase. Open
public function I_can_ask_it_for_gender_and_get_opposite()
{
$lookMars = ProfileCode::getIt(ProfileCode::LOOK_MARS);
self::assertTrue($lookMars->isMars());
self::assertFalse($lookMars->isVenus());- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_can_get_all_codes_at_once_or_by_similarly_named_constant is not named in camelCase. Open
public function I_can_get_all_codes_at_once_or_by_similarly_named_constant()
{
$reflection = new \ReflectionClass(self::getSutClass());
$constants = $reflection->getConstants();
asort($constants);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}