jaroslavtyc/drd-plus-codes

View on GitHub
tests/Codes/Transport/RidingAnimalMovementCodeTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\DrdPlus\Codes\Transport\RidingAnimalMovementCode' in method 'I_can_get_movements_without_jump'.
Open

        $allValues = RidingAnimalMovementCode::getPossibleValues();

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Transport\RidingAnimalMovementCode' in method 'I_can_get_movements_without_jump'.
Open

        self::assertSame($withoutJumping, RidingAnimalMovementCode::getPossibleValuesWithoutJumping());

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method I_can_get_movements_without_jump is not named in camelCase.
Open

    public function I_can_get_movements_without_jump()
    {
        $allValues = RidingAnimalMovementCode::getPossibleValues();
        self::assertContains(RidingAnimalMovementCode::JUMPING, $allValues);
        $withoutJumping = array_filter($allValues, function (string $movement) {

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status