jaroslavtyc/drd-plus-gaming-session

View on GitHub
tests/GamingSession/MemoriesTest.php

Summary

Maintainability
A
1 hr
Test Coverage

Method I_can_use_it has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function I_can_use_it(): void
    {
        $memories = new Memories();

        $firstAdventureExperienceValues = [];
Severity: Minor
Found in tests/GamingSession/MemoriesTest.php - About 1 hr to fix

    Avoid excessively long variable names like $firstAdventureExperienceValues. Keep variable name length under 20.
    Open

            $firstAdventureExperienceValues = [];
    Severity: Minor
    Found in tests/GamingSession/MemoriesTest.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $secondAdventureExperienceValue. Keep variable name length under 20.
    Open

            $secondAdventureExperienceValue = [];
    Severity: Minor
    Found in tests/GamingSession/MemoriesTest.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    The method I_can_use_it is not named in camelCase.
    Open

        public function I_can_use_it(): void
        {
            $memories = new Memories();
    
            $firstAdventureExperienceValues = [];
    Severity: Minor
    Found in tests/GamingSession/MemoriesTest.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
        public function get_name() {
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status