jaroslavtyc/drd-plus-health

Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.

Open

        Health $health,
        AfflictionProperty $property,
        AfflictionDangerousness $dangerousness,
        AfflictionDomain $domain,
        AfflictionVirulence $virulence,

The method __construct has 11 parameters. Consider reducing the number of parameters to less than 10.

Open

    protected function __construct(
        Health $health,
        AfflictionProperty $property,
        AfflictionDangerousness $dangerousness,
        AfflictionDomain $domain,

• Exclude checks
  • Disable engine
  • Disable check

The class Affliction has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13.

Open

abstract class Affliction extends StrictObject
{
    /**
     * @var \DrdPlus\Health\Health
     */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}