jaroslavtyc/drd-plus-health

View on GitHub
Health/HealingPower.php

Summary

Maintainability
A
1 hr
Test Coverage

Method createForRegeneration has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        RaceCode $raceCode,
        SubRaceCode $subRaceCode,
        Toughness $toughness,
        ActivityAffectingHealingCode $activityAffectingHealingCode,
        ConditionsAffectingHealingCode $conditionsAffectingHealingCode,
Severity: Major
Found in Health/HealingPower.php - About 1 hr to fix

    Avoid excessively long variable names like $conditionsAffectingHealingCode. Keep variable name length under 20.
    Open

            ConditionsAffectingHealingCode $conditionsAffectingHealingCode,
    Severity: Minor
    Found in Health/HealingPower.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $healingConditionsPercents. Keep variable name length under 20.
    Open

            HealingConditionsPercents $healingConditionsPercents,
    Severity: Minor
    Found in Health/HealingPower.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $activityAffectingHealingCode. Keep variable name length under 20.
    Open

            ActivityAffectingHealingCode $activityAffectingHealingCode,
    Severity: Minor
    Found in Health/HealingPower.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status