Avoid using static access to class '\DrdPlus\Health\Afflictions\AfflictionSize' in method 'I_can_not_use_negative_value'. Open
AfflictionSize::getEnum(-1);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Health\Afflictions\AfflictionSize' in method 'I_am_stopped_by_specific_exception_on_invalid_value'. Open
AfflictionSize::getIt('Broken heart by fixed dart');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Health\Afflictions\AfflictionSize' in method 'I_can_use_it_as_an_integer'. Open
$afflictionSize = AfflictionSize::getIt(123);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method I_can_not_use_negative_value is not named in camelCase. Open
public function I_can_not_use_negative_value()
{
$this->expectException(\DrdPlus\Health\Afflictions\Exceptions\AfflictionSizeCanNotBeNegative::class);
$this->expectExceptionMessageMatches('~-1~');
AfflictionSize::getEnum(-1);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_can_use_it_as_an_integer is not named in camelCase. Open
public function I_can_use_it_as_an_integer()
{
$afflictionSize = AfflictionSize::getIt(123);
self::assertInstanceOf(IntegerInterface::class, $afflictionSize);
self::assertSame(123, $afflictionSize->getValue());- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_am_stopped_by_specific_exception_on_invalid_value is not named in camelCase. Open
public function I_am_stopped_by_specific_exception_on_invalid_value()
{
$this->expectException(\Granam\IntegerEnum\Exceptions\WrongValueForIntegerEnum::class);
$this->expectExceptionMessageMatches('~Broken heart by fixed dart~');
AfflictionSize::getIt('Broken heart by fixed dart');- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}