Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star
tests/Health/Afflictions/AfflictionTest.php

Summary

Maintainability
A
0 mins
Test Coverage

The class AfflictionTest has 11 public methods. Consider refactoring AfflictionTest to keep number of public methods under 10.
Open

abstract class AfflictionTest extends TestWithMockery
{

    /**
     * @test
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The method I_get_all_maluses_zero_or_lesser is not named in camelCase.
Open

    public function I_get_all_maluses_zero_or_lesser()
    {
        $affliction = $this->getSut();
        self::assertLessThanOrEqual(0, $affliction->getStrengthMalus());
        self::assertLessThanOrEqual(0, $affliction->getAgilityMalus());
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    abstract public function I_can_use_it();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_strength_malus is not named in camelCase.
Open

    abstract public function I_can_get_strength_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_malus_to_activities is not named in camelCase.
Open

    abstract public function I_can_get_malus_to_activities();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_will_malus is not named in camelCase.
Open

    abstract public function I_can_get_will_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_intelligence_malus is not named in camelCase.
Open

    abstract public function I_can_get_intelligence_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_agility_malus is not named in camelCase.
Open

    abstract public function I_can_get_agility_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_charisma_malus is not named in camelCase.
Open

    abstract public function I_can_get_charisma_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_knack_malus is not named in camelCase.
Open

    abstract public function I_can_get_knack_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_linked_with_health_immediately is not named in camelCase.
Open

    abstract public function It_is_linked_with_health_immediately();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_heal_malus is not named in camelCase.
Open

    abstract public function I_can_get_heal_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status