tests/Health/Afflictions/Effects/HungerEffectTest.php
Avoid using static access to class '\DrdPlus\Health\Afflictions\Effects\HungerEffect' in method 'I_can_find_out_if_apply_even_on_success_against_trap'. Open
Open
$hungerEffect = HungerEffect::getIt();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method I_can_find_out_if_apply_even_on_success_against_trap is not named in camelCase. Open
Open
public function I_can_find_out_if_apply_even_on_success_against_trap()
{
$hungerEffect = HungerEffect::getIt();
self::assertTrue($hungerEffect->isEffectiveEvenOnSuccessAgainstTrap());
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}