Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star
tests/Health/Afflictions/Effects/SeveredArmEffectTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\DrdPlus\Health\Afflictions\Effects\SeveredArmEffect' in method 'I_can_find_out_if_apply_even_on_success_against_trap'.
Open

        $severedArmEffect = SeveredArmEffect::getIt();
Severity: Minor
Found in tests/Health/Afflictions/Effects/SeveredArmEffectTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\AfflictionSize' in method 'createSeveredArm'.
Open

            ->andReturn(AfflictionSize::getIt($serverArmSize));
Severity: Minor
Found in tests/Health/Afflictions/Effects/SeveredArmEffectTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\Afflictions\Effects\SeveredArmEffect' in method 'I_can_get_strength_and_knack_malus'.
Open

        $severedArmEffect = SeveredArmEffect::getIt();
Severity: Minor
Found in tests/Health/Afflictions/Effects/SeveredArmEffectTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method I_can_get_strength_and_knack_malus is not named in camelCase.
Open

    public function I_can_get_strength_and_knack_malus()
    {
        $severedArmEffect = SeveredArmEffect::getIt();
        self::assertSame(-123, $severedArmEffect->getStrengthMalus($this->createSeveredArm(123)));
        self::assertSame(-246, $severedArmEffect->getKnackMalus($this->createSeveredArm(123)));
Severity: Minor
Found in tests/Health/Afflictions/Effects/SeveredArmEffectTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_apply_even_on_success_against_trap is not named in camelCase.
Open

    public function I_can_find_out_if_apply_even_on_success_against_trap()
    {
        $severedArmEffect = SeveredArmEffect::getIt();
        self::assertTrue($severedArmEffect->isEffectiveEvenOnSuccessAgainstTrap());
    }
Severity: Minor
Found in tests/Health/Afflictions/Effects/SeveredArmEffectTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status