The class BleedingTest has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13. Open
class BleedingTest extends AfflictionByWoundTest
{
/**
* @return Bleeding
*/- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Bleeding' in method 'I_can_get_heal_malus'. Open
$bleeding = Bleeding::createIt($wound, $woundBoundary);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Bleeding' in method 'I_can_use_it'. Open
$bleeding = Bleeding::createIt($wound, $woundBoundary);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Bleeding' in method 'I_can_get_knack_malus'. Open
$bleeding = Bleeding::createIt($wound, $woundBoundary);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Bleeding' in method 'I_can_get_agility_malus'. Open
$bleeding = Bleeding::createIt($wound, $woundBoundary);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Bleeding' in method 'I_can_get_strength_malus'. Open
$bleeding = Bleeding::createIt($wound, $woundBoundary);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Bleeding' in method 'I_can_get_malus_to_activities'. Open
$bleeding = Bleeding::createIt($wound, $woundBoundary);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Bleeding' in method 'I_can_not_create_it_from_too_low_wound'. Open
Bleeding::createIt($wound, $woundBoundary);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Health\Afflictions\SpecificAfflictions\Bleeding' in method 'getSut'. Open
return Bleeding::createIt($wound, $woundBoundary);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused local variables such as '$filledHalfOfRows'. Open
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$filledHalfOfRows'. Open
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$filledHalfOfRows'. Open
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$filledHalfOfRows'. Open
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$filledHalfOfRows'. Open
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The method I_can_get_heal_malus is not named in camelCase. Open
public function I_can_get_heal_malus()
{
$wound = $this->createWound();
$woundBoundary = $this->createWoundBoundary(20);
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_can_not_create_it_from_too_low_wound is not named in camelCase. Open
public function I_can_not_create_it_from_too_low_wound()
{
$this->expectException(\DrdPlus\Health\Afflictions\SpecificAfflictions\Exceptions\BleedingCanNotExistsDueToTooLowWound::class);
$wound = $this->createWound();
$woundBoundary = $this->createWoundBoundary(5);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_can_get_strength_malus is not named in camelCase. Open
public function I_can_get_strength_malus()
{
$wound = $this->createWound();
$woundBoundary = $this->createWoundBoundary(20);
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_can_get_agility_malus is not named in camelCase. Open
public function I_can_get_agility_malus()
{
$wound = $this->createWound();
$woundBoundary = $this->createWoundBoundary(20);
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_can_use_it is not named in camelCase. Open
public function I_can_use_it()
{
$wound = $this->createWound();
$woundBoundary = $this->createWoundBoundary(20);
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_can_get_knack_malus is not named in camelCase. Open
public function I_can_get_knack_malus()
{
$wound = $this->createWound();
$woundBoundary = $this->createWoundBoundary(20);
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method I_can_get_malus_to_activities is not named in camelCase. Open
public function I_can_get_malus_to_activities()
{
$wound = $this->createWound();
$woundBoundary = $this->createWoundBoundary(20);
$this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}