Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star
tests/Health/HealingPowerTest.php

Summary

Maintainability
A
0 mins
Test Coverage

The class HealingPowerTest has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13.
Open

class HealingPowerTest extends TestWithMockery
{
    /**
     * @test
     */
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Avoid using static access to class '\DrdPlus\Health\HealingPower' in method 'I_can_use_it_for_treatment'.
Open

        $healingPower = HealingPower::createForTreatment(
            123,
            $this->createToughness(3),
            $this->createTablesWithWoundsTable(126, 999)
        );
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Health\HealingPower' in method 'I_can_use_it_for_regeneration'.
Open

            $healingPower = HealingPower::createForRegeneration(
                $raceCode,
                $subRaceCode,
                $this->createToughness(-5),
                $this->createActivityCode('baz'),
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid excessively long variable names like $hasNativeRegeneration. Keep variable name length under 20.
Open

        foreach ([true, false] as $hasNativeRegeneration) {
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $healingConditionsPercents. Keep variable name length under 20.
Open

            $healingConditionsPercents = $this->createHealingConditionsPercents();
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $healingByActivityTable. Keep variable name length under 20.
Open

        $healingByActivityTable = $this->mockery(HealingByActivityTable::class);
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $hasNativeRegeneration. Keep variable name length under 20.
Open

    private function createRacesTable(RaceCode $expectedRaceCode, SubRaceCode $expectedSubRaceCode, $hasNativeRegeneration)
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $healingByConditionsTable. Keep variable name length under 20.
Open

        $healingByConditionsTable = $this->mockery(HealingByConditionsTable::class);
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The method I_can_use_it_for_treatment is not named in camelCase.
Open

    public function I_can_use_it_for_treatment(): void
    {
        $healingPower = HealingPower::createForTreatment(
            123,
            $this->createToughness(3),
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it_for_regeneration is not named in camelCase.
Open

    public function I_can_use_it_for_regeneration(): void
    {
        foreach ([true, false] as $hasNativeRegeneration) {
            $tables = $this->createTablesWithWoundsTable($expectedValue = -7 + 123 + 456 + 789 + ($hasNativeRegeneration ? +4 : 0) - 5 /* toughness */, 112233);
            $tables->shouldReceive('getHealingByActivityTable')
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status