Sign upLogin

jaroslavtyc/drd-plus-profession-levels

View on GitHub
Star

Showing 345 of 345 total issues

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
        self::assertInstanceOf(ProfessionZeroLevel::class, $professionZeroLevel);
        self::assertSame($commoner, $professionZeroLevel->getProfession());
Severity: Minor
Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_it_with_higher_level_thank_zero is not named in camelCase.
Open

    public function I_can_not_create_it_with_higher_level_thank_zero()
    {
        $this->expectException(\DrdPlus\Person\ProfessionLevels\Exceptions\InvalidZeroLevelRank::class);
        $this->expectExceptionMessageMatches('~[^\d]0[^\d]~');
        $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
Severity: Minor
Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_next_level_with_too_high_property_increment is not named in camelCase.
Open

    public function I_can_not_create_next_level_with_too_high_property_increment($propertyCodeTooHigh)
    {
        $this->expectException(\DrdPlus\Person\ProfessionLevels\Exceptions\TooHighNextLevelPropertyIncrement::class);
        ProfessionNextLevel::createNextLevel(
            $this->createProfession(ProfessionCode::FIGHTER),
Severity: Minor
Found in tests/Person/ProfessionLevels/ProfessionNextLevelTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_set_and_get_profession_levels is not named in camelCase.
Open

    public function I_can_set_and_get_profession_levels()
    {
        $professionNextLevel = ProfessionNextLevel::createNextLevel(
            $this->createProfession(ProfessionCode::FIGHTER),
            $this->createLevelRank(2),
Severity: Minor
Found in tests/Person/ProfessionLevels/ProfessionNextLevelTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_it_with_property_increment is not named in camelCase.
Open

    public function I_can_not_create_it_with_property_increment(
        Strength $strength,
        Agility $agility,
        Knack $knack,
        Will $will,
Severity: Minor
Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language