jaroslavtyc/drd-plus-profession-levels

Method createNextLevel has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

        Profession $profession,
        LevelRank $nextLevelRank,
        Strength $strengthIncrement,
        Agility $agilityIncrement,
        Knack $knackIncrement,

The class ProfessionNextLevel has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.

Open

class ProfessionNextLevel extends ProfessionLevel
{
    private ?\DrdPlus\Person\ProfessionLevels\ProfessionLevels $professionLevels = null;

    /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Avoid unused parameters such as '$profession'.

Open

    protected function checkPropertyIncrement(BaseProperty $baseProperty, Profession $profession)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid excessively long variable names like $intelligenceIncrement. Keep variable name length under 20.

Open

        Intelligence $intelligenceIncrement,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}