Sign upLogin

jaroslavtyc/drd-plus-profession-levels

View on GitHub
Star
src/ProfessionLevels/ProfessionZeroLevel.php

Summary

Maintainability
A
0 mins
Test Coverage

The class ProfessionZeroLevel has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
Open

class ProfessionZeroLevel extends ProfessionLevel
{
    /**
     * @param Commoner $commoner
     * @param \DateTimeImmutable|null $levelUpAt
Severity: Minor
Found in src/ProfessionLevels/ProfessionZeroLevel.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Avoid using static access to class '\DrdPlus\BaseProperties\Agility' in method 'createZeroLevel'.
Open

            Agility::getIt(0),
Severity: Minor
Found in src/ProfessionLevels/ProfessionZeroLevel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\BaseProperties\Intelligence' in method 'createZeroLevel'.
Open

            Intelligence::getIt(0),
Severity: Minor
Found in src/ProfessionLevels/ProfessionZeroLevel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\BaseProperties\Knack' in method 'createZeroLevel'.
Open

            Knack::getIt(0),
Severity: Minor
Found in src/ProfessionLevels/ProfessionZeroLevel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\BaseProperties\Strength' in method 'createZeroLevel'.
Open

            Strength::getIt(0),
Severity: Minor
Found in src/ProfessionLevels/ProfessionZeroLevel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\BaseProperties\Charisma' in method 'createZeroLevel'.
Open

            Charisma::getIt(0),
Severity: Minor
Found in src/ProfessionLevels/ProfessionZeroLevel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\BaseProperties\Will' in method 'createZeroLevel'.
Open

            Will::getIt(0),
Severity: Minor
Found in src/ProfessionLevels/ProfessionZeroLevel.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$profession'.
Open

    protected function checkPropertyIncrement(BaseProperty $baseProperty, Profession $profession)
Severity: Minor
Found in src/ProfessionLevels/ProfessionZeroLevel.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There are no issues that match your filters.

Category
Status