Sign upLogin

jaroslavtyc/drd-plus-profession-levels

View on GitHub
Star
tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php

Summary

Maintainability
A
45 mins
Test Coverage

Method I_can_not_create_it_with_property_increment has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Strength $strength,
        Agility $agility,
        Knack $knack,
        Will $will,
        Intelligence $intelligence,
Severity: Minor
Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php - About 45 mins to fix

    The class ProfessionZeroLevelTest has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
    Open

    class ProfessionZeroLevelTest extends TestCase
{
    /**
     * @test
     */
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Missing class import via use statement (line '96', column '27').
    Open

            $reflection = new \ReflectionClass(ProfessionZeroLevel::class);
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '43', column '25').
    Open

                $when = new \DateTimeImmutable('2016-10-09 19:06:00T+02:00')
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '56', column '27').
    Open

            $reflection = new \ReflectionClass(ProfessionZeroLevel::class);
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'DrdPlus\Person\ProfessionLevels\ProfessionZeroLevel' in method 'I_can_use_it'.
    Open

            $professionZeroLevel = ProfessionZeroLevel::createZeroLevel(
            Commoner::getIt(),
            $when = new \DateTimeImmutable('2016-10-09 19:06:00T+02:00')
        );
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\Professions\Commoner' in method 'I_can_use_it'.
    Open

                Commoner::getIt(),
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\Professions\Commoner' in method 'I_can_not_create_it_with_higher_level_thank_zero'.
    Open

            $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\BaseProperties\Knack' in method 'I_can_not_create_it_with_higher_level_thank_zero'.
    Open

                    Knack::getIt(0),
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\BaseProperties\Will' in method 'I_can_not_create_it_with_higher_level_thank_zero'.
    Open

                    Will::getIt(0),
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\Professions\Commoner' in method 'I_can_use_it'.
    Open

            $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'DrdPlus\Person\ProfessionLevels\LevelRank' in method 'I_can_not_create_it_with_higher_level_thank_zero'.
    Open

                    LevelRank::getIt(1),
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\BaseProperties\Strength' in method 'I_can_not_create_it_with_higher_level_thank_zero'.
    Open

                    Strength::getIt(0),
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'DrdPlus\Person\ProfessionLevels\LevelRank' in method 'I_can_not_create_it_with_property_increment'.
    Open

                [$commoner, LevelRank::getIt(0), $strength, $agility, $knack, $will, $intelligence, $charisma]
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\Professions\Commoner' in method 'I_can_not_create_it_with_property_increment'.
    Open

            $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\BaseProperties\Intelligence' in method 'I_can_not_create_it_with_higher_level_thank_zero'.
    Open

                    Intelligence::getIt(0),
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'DrdPlus\Person\ProfessionLevels\ProfessionZeroLevel' in method 'I_can_use_it'.
    Open

            $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\BaseProperties\Charisma' in method 'I_can_not_create_it_with_higher_level_thank_zero'.
    Open

                    Charisma::getIt(0),
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'DrdPlus\Person\ProfessionLevels\ProfessionZeroLevel' in method 'I_can_not_create_it_with_higher_level_thank_zero'.
    Open

            $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\DrdPlus\BaseProperties\Agility' in method 'I_can_not_create_it_with_higher_level_thank_zero'.
    Open

                    Agility::getIt(0),
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'DrdPlus\Person\ProfessionLevels\ProfessionZeroLevel' in method 'I_can_not_create_it_with_property_increment'.
    Open

            $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid excessively long variable names like $incrementedProperties. Keep variable name length under 20.
    Open

                $incrementedProperties = [];
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    The method I_can_use_it is not named in camelCase.
    Open

        public function I_can_use_it()
    {
        $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
        self::assertInstanceOf(ProfessionZeroLevel::class, $professionZeroLevel);
        self::assertSame($commoner, $professionZeroLevel->getProfession());
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method I_can_not_create_it_with_property_increment is not named in camelCase.
    Open

        public function I_can_not_create_it_with_property_increment(
        Strength $strength,
        Agility $agility,
        Knack $knack,
        Will $will,
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    The method I_can_not_create_it_with_higher_level_thank_zero is not named in camelCase.
    Open

        public function I_can_not_create_it_with_higher_level_thank_zero()
    {
        $this->expectException(\DrdPlus\Person\ProfessionLevels\Exceptions\InvalidZeroLevelRank::class);
        $this->expectExceptionMessageMatches('~[^\d]0[^\d]~');
        $professionZeroLevel = ProfessionZeroLevel::createZeroLevel($commoner = Commoner::getIt());
    Severity: Minor
    Found in tests/Person/ProfessionLevels/ProfessionZeroLevelTest.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status