Sign upLogin

jaroslavtyc/drd-plus-professions

View on GitHub
Star

Showing 15 of 15 total issues

Avoid excessively long variable names like $professionPrimaryPropertiesTable. Keep variable name length under 20.
Open

        $professionPrimaryPropertiesTable = new ProfessionPrimaryPropertiesTable();
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid using static access to class '\DrdPlus\Codes\Properties\PropertyCode' in method 'I_can_detect_primary_property'.
Open

            $profession->isPrimaryProperty(PropertyCode::getIt($propertyCode)),
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\ProfessionCode' in method 'I_can_create_every_profession_by_code'.
Open

        foreach (ProfessionCode::getPossibleValues() as $professionCode) {
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\ProfessionCode' in method 'I_can_create_every_profession_by_code'.
Open

            $profession = Profession::getItByCode(ProfessionCode::getIt($professionCode));
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\ProfessionCode' in method 'getCode'.
Open

        return ProfessionCode::getIt($this->getValue());
Severity: Minor
Found in src/Profession.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Professions\Profession' in method 'I_can_create_every_profession_by_code'.
Open

            $profession = Profession::getItByCode(ProfessionCode::getIt($professionCode));
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\ProfessionCode' in method 'getExpectedPrimaryProperties'.
Open

            $professionPrimaryPropertiesTable->getPrimaryPropertiesOf(ProfessionCode::getIt($this->getProfessionName()))
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'getItByCode'.
Open

                'No profession found by code ' . ValueDescriber::describe($professionCode)
Severity: Minor
Found in src/Profession.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Professions\Profession' in method 'I_can_not_create_profession_by_unknown_code'.
Open

        Profession::getItByCode($professionCode);
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method I_can_create_every_profession_by_code is not named in camelCase.
Open

    public function I_can_create_every_profession_by_code()
    {
        foreach (ProfessionCode::getPossibleValues() as $professionCode) {
            $profession = Profession::getItByCode(ProfessionCode::getIt($professionCode));
            $namespace = str_replace('Tests\\', '', __NAMESPACE__);
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_profession_and_get_its_code is not named in camelCase.
Open

    public function I_can_create_profession_and_get_its_code(): Profession
    {
        $professionClass = self::getSutClass();
        /** @var Profession|Fighter $professionClass */
        $profession = $professionClass::getIt();
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_profession_code is not named in camelCase.
Open

    public function I_can_get_profession_code()
    {
        $professionClass = self::getSutClass();
        /** @var Profession|Fighter $professionClass */
        $profession = $professionClass::getIt();
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_profession_by_unknown_code is not named in camelCase.
Open

    public function I_can_not_create_profession_by_unknown_code()
    {
        $this->expectException(\DrdPlus\Professions\Exceptions\ProfessionNotFound::class);
        /** @var ProfessionCode|\Mockery\MockInterface $professionCode */
        $professionCode = $this->mockery(ProfessionCode::class);
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_primary_properties is not named in camelCase.
Open

    public function I_can_get_primary_properties()
    {
        $professionClass = self::getSutClass();
        /** @var Profession|Fighter $professionClass */
        $profession = $professionClass::getIt();
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_detect_primary_property is not named in camelCase.
Open

    public function I_can_detect_primary_property($propertyCode, $shouldBePrimary)
    {
        $professionClass = self::getSutClass();
        /** @var Profession|Fighter $professionClass */
        $profession = $professionClass::getIt();
Severity: Minor
Found in tests/Professions/ProfessionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language