jaroslavtyc/drd-plus-properties-by-levels

View on GitHub
DrdPlus/Tests/PropertiesByLevels/FirstLevelPropertiesTest.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method I_can_get_every_property_both_limited_and_unlimited has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function I_can_get_every_property_both_limited_and_unlimited(
        int $strength,
        int $agility,
        int $knack,
        int $will,
Severity: Major
Found in DrdPlus/Tests/PropertiesByLevels/FirstLevelPropertiesTest.php - About 2 hrs to fix

    Method createPropertiesByFate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function createPropertiesByFate(
            int $strength,
            int $agility,
            int $knack,
            int $will,
    Severity: Minor
    Found in DrdPlus/Tests/PropertiesByLevels/FirstLevelPropertiesTest.php - About 1 hr to fix

      Method createPropertiesByFate has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              int $strength,
              int $agility,
              int $knack,
              int $will,
              int $intelligence,
      Severity: Minor
      Found in DrdPlus/Tests/PropertiesByLevels/FirstLevelPropertiesTest.php - About 45 mins to fix

        Method I_can_get_every_property_both_limited_and_unlimited has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                int $strength,
                int $agility,
                int $knack,
                int $will,
                int $intelligence,
        Severity: Minor
        Found in DrdPlus/Tests/PropertiesByLevels/FirstLevelPropertiesTest.php - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $propertiesByFate;
          Severity: Major
          Found in DrdPlus/Tests/PropertiesByLevels/FirstLevelPropertiesTest.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return $this->createProperty($charisma, Charisma::class);
            Severity: Major
            Found in DrdPlus/Tests/PropertiesByLevels/FirstLevelPropertiesTest.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return $this->createProperty($intelligence, Intelligence::class);
              Severity: Major
              Found in DrdPlus/Tests/PropertiesByLevels/FirstLevelPropertiesTest.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status