src/Race.php
The class Race has an overall complexity of 51 which is very high. The configured complexity threshold is 50. Open
Open
abstract class Race extends ScalarEnum
{
/**
* @param string|StringInterface $value
* @throws Exceptions\UnknownRaceCode- Exclude checks
Race has 25 functions (exceeds 20 allowed). Consider refactoring. Open
Open
abstract class Race extends ScalarEnum
{
/**
* @param string|StringInterface $value
* @throws Exceptions\UnknownRaceCodeMethod getProperty has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getProperty(PropertyCode $propertyCode, GenderCode $genderCode, Tables $tables)
{
switch ($propertyCode->getValue()) {
case PropertyCode::STRENGTH :
return $this->getStrength($genderCode, $tables);Avoid too many return statements within this method. Open
Open
return $this->getIntelligence($genderCode, $tables);Avoid too many return statements within this method. Open
Open
return $this->getCharisma($genderCode, $tables);Avoid too many return statements within this method. Open
Open
return $this->getBodyWeight($genderCode, $tables);Avoid too many return statements within this method. Open
Open
return $this->getHeightInCm($tables);Avoid too many return statements within this method. Open
Open
return $this->getSize($genderCode, $tables);Avoid too many return statements within this method. Open
Open
return $this->getRemarkableSense($tables);Avoid too many return statements within this method. Open
Open
return $this->hasNativeRegeneration($tables);Avoid too many return statements within this method. Open
Open
return $this->requiresDmAgreement($tables);Avoid too many return statements within this method. Open
Open
return $this->getToughness($tables);Avoid too many return statements within this method. Open
Open
return $this->getHeight($tables);Avoid too many return statements within this method. Open
Open
return $this->hasInfravision($tables);Avoid too many return statements within this method. Open
Open
return $this->getWeightInKg($genderCode, $tables);Avoid too many return statements within this method. Open
Open
return $this->getAge($tables);Avoid too many return statements within this method. Open
Open
return $this->getSenses($tables);The method getProperty() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10. Open
Open
public function getProperty(PropertyCode $propertyCode, GenderCode $genderCode, Tables $tables)
{
switch ($propertyCode->getValue()) {
case PropertyCode::STRENGTH :
return $this->getStrength($genderCode, $tables);- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'checkRaceEnumValue'. Open
Open
. ' got ' . ValueDescriber::describe($value)- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'getProperty'. Open
Open
'Unknown property ' . ValueDescriber::describe($propertyCode)- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}