Sign upLogin

jaroslavtyc/drd-plus-rolls-on

View on GitHub
Star
tests/RollsOn/QualityAndSuccess/BasicRollOnSuccessTest.php

Summary

Maintainability
A
0 mins
Test Coverage

The method I_can_use_it uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            self::assertFalse($basicRollOnSuccess->getValue());
            self::assertFalse($basicRollOnSuccess->isSuccess());
            self::assertTrue($basicRollOnSuccess->isFailure());
            self::assertSame('failure', (string)$basicRollOnSuccess);
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/BasicRollOnSuccessTest.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it($difficulty, RollOnQuality $rollOnQuality, $shouldSuccess)
    {
        $basicRollOnSuccess = new BasicRollOnSuccess($difficulty, $rollOnQuality);

        self::assertInstanceOf(BooleanInterface::class, $basicRollOnSuccess);
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/BasicRollOnSuccessTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status