jaroslavtyc/drd-plus-rolls-on

Method I_can_find_out_if_failed_just_moderately has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

        $roll,
        $defiance,
        $ride,
        $ridingSkill,
        $previousFailuresCount,

Method I_can_find_out_if_failed_fatally has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function I_can_find_out_if_failed_fatally($roll, $defiance, $ride, $ridingSkill, $previousFailuresCount, $isFatalFailure)

Avoid excessively long variable names like $previousFailuresCount. Keep variable name length under 20.

Open

        $previousFailuresCount,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $previousFailuresCount. Keep variable name length under 20.

Open

        $previousFailuresCount = $this->mockery(PreviousFailuresCount::class);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $previousFailuresCount. Keep variable name length under 20.

Open

    public function I_can_find_out_if_failed_fatally($roll, $defiance, $ride, $ridingSkill, $previousFailuresCount, $isFatalFailure)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

The method I_can_find_out_if_failed_just_moderately is not named in camelCase.

Open

    public function I_can_find_out_if_failed_just_moderately(
        $roll,
        $defiance,
        $ride,
        $ridingSkill,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method I_can_find_out_if_failed_fatally is not named in camelCase.

Open

    public function I_can_find_out_if_failed_fatally($roll, $defiance, $ride, $ridingSkill, $previousFailuresCount, $isFatalFailure)
    {
        $rollOnAnimalControl = new RollOnAnimalControl(
            $this->createRollOnAgility($roll),
            $this->createAnimalDefiance($defiance),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method I_can_use_it is not named in camelCase.

Open

    public function I_can_use_it()
    {
        $rollOnAnimalControl = new RollOnAnimalControl(
            $rollOnAgility = $this->createRollOnAgility(321),
            $this->createAnimalDefiance(123),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}