Sign upLogin

jaroslavtyc/drd-plus-rolls-on

View on GitHub
Star
tests/RollsOn/QualityAndSuccess/RollOnKnowledgeTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid excessively long variable names like $shortRollOnIntelligence. Keep variable name length under 20.
Open

    public function I_can_fail_and_succeed(ShortRollOnIntelligence $shortRollOnIntelligence, $difficulty, $isSuccess, $expectedResult)
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/RollOnKnowledgeTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The method I_can_fail_and_succeed is not named in camelCase.
Open

    public function I_can_fail_and_succeed(ShortRollOnIntelligence $shortRollOnIntelligence, $difficulty, $isSuccess, $expectedResult)
    {
        $rollOnKnowledge = new RollOnKnowledge($shortRollOnIntelligence, $difficulty);
        self::assertInstanceOf(ExtendedRollOnSuccess::class, $rollOnKnowledge);
        self::assertSame($isSuccess, $rollOnKnowledge->isSuccess());
Severity: Minor
Found in tests/RollsOn/QualityAndSuccess/RollOnKnowledgeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status