Sign upLogin

jaroslavtyc/drd-plus-rolls-on

View on GitHub
Star
tests/RollsOn/Situations/RollOnFightTest.php

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function I_can_use_it()
    {
        $rollOnFight = new RollOnFight($fightNumber = 123, $roll2d6DrdPlus = $this->createRoll2d6DrdPlus($rollValue = 456));
        self::assertSame($fightNumber, $rollOnFight->getFightNumber());
        self::assertSame($roll2d6DrdPlus, $rollOnFight->getRoll2d6Plus());
Severity: Major
Found in tests/RollsOn/Situations/RollOnFightTest.php and 1 other location - About 1 hr to fix
tests/RollsOn/QualityAndSuccess/RollOnQualityTest.php on lines 14..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $expectedRollOnFightValue. Keep variable name length under 20.
Open

        $expectedRollOnFightValue = $fightNumber + $rollValue;
Severity: Minor
Found in tests/RollsOn/Situations/RollOnFightTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $rollOnFight = new RollOnFight($fightNumber = 123, $roll2d6DrdPlus = $this->createRoll2d6DrdPlus($rollValue = 456));
        self::assertSame($fightNumber, $rollOnFight->getFightNumber());
        self::assertSame($roll2d6DrdPlus, $rollOnFight->getRoll2d6Plus());
Severity: Minor
Found in tests/RollsOn/Situations/RollOnFightTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status