Sign upLogin

jaroslavtyc/drd-plus-rolls-on

View on GitHub
Star
tests/RollsOn/Traps/RollOnQualityTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '52', column '39').
Open

        $basePropertyNamespace = (new \ReflectionClass(BaseProperty::class))->getNamespaceName();
Severity: Minor
Found in tests/RollsOn/Traps/RollOnQualityTest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '57', column '42').
Open

        $derivedPropertyNamespace = (new \ReflectionClass(DerivedProperty::class))->getNamespaceName();
Severity: Minor
Found in tests/RollsOn/Traps/RollOnQualityTest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid excessively long variable names like $basePropertyNamespace. Keep variable name length under 20.
Open

        $basePropertyNamespace = (new \ReflectionClass(BaseProperty::class))->getNamespaceName();
Severity: Minor
Found in tests/RollsOn/Traps/RollOnQualityTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $derivedPropertyNamespace. Keep variable name length under 20.
Open

        $derivedPropertyNamespace = (new \ReflectionClass(DerivedProperty::class))->getNamespaceName();
Severity: Minor
Found in tests/RollsOn/Traps/RollOnQualityTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $basePropertyClassName. Keep variable name length under 20.
Open

        $basePropertyClassName = $basePropertyNamespace . '\\' . $propertyBasename;
Severity: Minor
Found in tests/RollsOn/Traps/RollOnQualityTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        /** @var RollOnQuality $rollOnProperty */
        $rollOnProperty = $this->createSutInstance(
            $property = $this->getPropertyInstance($propertyValue = 123),
Severity: Minor
Found in tests/RollsOn/Traps/RollOnQualityTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status