jaroslavtyc/drd-plus-rolls-on

View on GitHub
tests/RollsOn/Traps/RollOnSensesTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid excessively long variable names like $bonusFromUsedRemarkableSense. Keep variable name length under 20.
Open

            $bonusFromUsedRemarkableSense = $this->createBonusFromUsedRemarkableSense(789)

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $bonusFromUsedRemarkableSense. Keep variable name length under 20.
Open

        $bonusFromUsedRemarkableSense = $this->mockery(BonusFromUsedRemarkableSense::class);

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The method I_can_affect_it_by_bonus_from_used_remarkable_sense is not named in camelCase.
Open

    public function I_can_affect_it_by_bonus_from_used_remarkable_sense()
    {
        $rollOnSenses = new RollOnSenses(
            $senses = $this->createSenses(123),
            $roll2D6DrdPlus = $this->createRoll2d6DrdPlus(456),

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status