Sign upLogin

jaroslavtyc/drd-plus-searching

View on GitHub
Star

Showing 44 of 44 total issues

The class SearchingTest has 11 public methods. Consider refactoring SearchingTest to keep number of public methods under 10.
Open

class SearchingTest extends TestWithMockery
{

    /**
     * @test
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Avoid excessively long class names like ThoroughSearchCanNotBeMadeWhenDoingFullConcentrationActivity. Keep class name length under 40.
Open

class ThoroughSearchCanNotBeMadeWhenDoingFullConcentrationActivity extends NonAutomaticSearchCanNotBeMadeWhenDoingFullConcentrationActivity
{

}
Severity: Minor
Found in Searching/Exceptions/ThoroughSearchCanNotBeMadeWhenDoingFullConcentrationActivity.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Avoid excessively long variable names like $squareMetersToExplore. Keep variable name length under 20.
Open

    public function getQuickSearchTime(PositiveFloat $squareMetersToExplore, Tables $tables): Time
Severity: Minor
Found in Searching/Searching.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $stealthinessOnSituation. Keep variable name length under 20.
Open

    private function createTables(ItemStealthinessCode $itemStealthinessCode, $stealthinessOnSituation)
Severity: Minor
Found in tests/Searching/ItemStealthinessTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $squareMetersToExplore. Keep variable name length under 20.
Open

    public function I_can_get_time_of_thorough_search($squareMetersToExplore, $expectedTime, $expectedTimeUnit)
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $activityIntensityCode. Keep variable name length under 20.
Open

    private function createTables(ActivityIntensityCode $activityIntensityCode, $malus)
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long class names like NonAutomaticSearchCanNotBeMadeWhenDoingFullConcentrationActivity. Keep class name length under 40.
Open

class NonAutomaticSearchCanNotBeMadeWhenDoingFullConcentrationActivity extends \LogicException implements Logic
{

}
Severity: Minor
Found in Searching/Exceptions/NonAutomaticSearchCanNotBeMadeWhenDoingFullConcentrationActivity.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Avoid excessively long variable names like $searchingItemTypeCode. Keep variable name length under 20.
Open

    public function getThoroughSearchQuality(RollOnSenses $rollOnSenses, SearchingItemTypeCode $searchingItemTypeCode): int
Severity: Minor
Found in Searching/Searching.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long class names like QuickSearchCanNotBeMadeWhenDoingFullConcentrationActivity. Keep class name length under 40.
Open

class QuickSearchCanNotBeMadeWhenDoingFullConcentrationActivity extends NonAutomaticSearchCanNotBeMadeWhenDoingFullConcentrationActivity
{

}
Severity: Minor
Found in Searching/Exceptions/QuickSearchCanNotBeMadeWhenDoingFullConcentrationActivity.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Avoid excessively long variable names like $squareMetersToExplore. Keep variable name length under 20.
Open

    public function I_can_get_time_of_quick_search($squareMetersToExplore, $expectedTime, $expectedTimeUnit)
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $currentActivityIntensityCode. Keep variable name length under 20.
Open

    private $currentActivityIntensityCode;
Severity: Minor
Found in Searching/Searching.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $activityIntensityCode. Keep variable name length under 20.
Open

        $activityIntensityCode = ActivityIntensityCode::getIt(ActivityIntensityCode::AUTOMATIC_ACTIVITY);
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $currentActivityIntensityCode. Keep variable name length under 20.
Open

    public function __construct(ActivityIntensityCode $currentActivityIntensityCode)
Severity: Minor
Found in Searching/Searching.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The class SearchingTest has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
Open

class SearchingTest extends TestWithMockery
{

    /**
     * @test
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

The method createRollOnSenses has a boolean flag argument $withBonus, which is a certain sign of a Single Responsibility Principle violation.
Open

    private function createRollOnSenses($sensesValue, $withBonus = false)
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid using static access to class '\DrdPlus\Codes\SearchingItemTypeCode' in method 'I_can_make_thorough_search'.
Open

                    SearchingItemTypeCode::getIt($searchingItemType)
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Granam\Integer\Tools\ToInteger' in method '__construct'.
Open

        $this->value = ToInteger::toInteger($value);
Severity: Minor
Found in Searching/ItemStealthiness.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\ActivityIntensityCode' in method 'I_can_not_make_quick_search_when_doing_full_concentration_activity'.
Open

        (new Searching(ActivityIntensityCode::getIt(ActivityIntensityCode::ACTIVITY_WITH_FULL_CONCENTRATION)))
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'I_can_get_time_of_thorough_search'.
Open

                Tables::getIt()
Severity: Minor
Found in tests/Searching/SearchingTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'getQuickSearchTime'.
Open

            $timeValue = SumAndRound::ceil($squareMetersToExplore->getValue() / 10);
Severity: Minor
Found in Searching/Searching.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language