Sign upLogin

jaroslavtyc/drd-plus-stamina

View on GitHub
Star
Stamina/MalusFromFatigue.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\DrdPlus\Calculations\SumAndRound' in method 'getValueForActivity'.
Open

        return SumAndRound::half($this->getValue());
Severity: Minor
Found in Stamina/MalusFromFatigue.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'convertToEnumFinalValue'.
Open

                'Malus can be between 0 and ' . self::MOST . ', got ' . ValueDescriber::describe($enumValue)
Severity: Minor
Found in Stamina/MalusFromFatigue.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There are no issues that match your filters.

Category
Status