Sign upLogin

jaroslavtyc/drd-plus-stamina

View on GitHub
Star

Showing 88 of 88 total issues

The method Malus_can_increase_on_new_fatigue is not named in camelCase.
Open

    public function Malus_can_increase_on_new_fatigue(int $willValue, int $rollValue, int $expectedMalus): void
    {
        $fatigueBoundary = $this->createFatigueBoundary(5);
        $stamina = $this->createStaminaToTest($fatigueBoundary);
Severity: Minor
Found in tests/Stamina/StaminaTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Malus_is_not_increased_on_new_rest_by_worse_roll is not named in camelCase.
Open

    public function Malus_is_not_increased_on_new_rest_by_worse_roll(): void
    {
        $fatigueBoundary = $this->createFatigueBoundary(5);
        $stamina = $this->createStaminaToTest($fatigueBoundary);
        self::assertSame(0, $stamina->getMalusFromFatigue($fatigueBoundary)->getValue());
Severity: Minor
Found in tests/Stamina/StaminaTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_it_if_may_suffer_from_fatigue is not named in camelCase.
Open

    public function I_can_ask_it_if_may_suffer_from_fatigue(): void
    {
        $fatigueBoundary = $this->createFatigueBoundary(5);
        $stamina = $this->createStaminaToTest($fatigueBoundary);
        self::assertFalse($stamina->maySufferFromFatigue($fatigueBoundary));
Severity: Minor
Found in tests/Stamina/StaminaTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_maximum_of_fatigues_per_row is not named in camelCase.
Open

    public function I_can_get_maximum_of_fatigues_per_row(): void
    {
        $fatigueBoundary = $this->createFatigueBoundary(123);
        $gridOfFatigueWithoutFatigueAtAll = new GridOfFatigue($this->createStamina(0 /* no fatigue */));
        self::assertSame(123, $gridOfFatigueWithoutFatigueAtAll->getFatiguePerRowMaximum($fatigueBoundary));
Severity: Minor
Found in tests/Stamina/GridOfFatigueTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_add_new_fatigue_if_roll_on_malus_expected is not named in camelCase.
Open

    public function I_can_not_add_new_fatigue_if_roll_on_malus_expected(): void
    {
        $fatigueBoundary = $this->createFatigueBoundary(10);
        $stamina = $this->createStaminaToTest($fatigueBoundary);
        $stamina->addFatigue($this->createFatigue(10), $fatigueBoundary);
Severity: Minor
Found in tests/Stamina/StaminaTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_number_of_filled_rows is not named in camelCase.
Open

    public function I_can_get_number_of_filled_rows(): void
    {
        $fatigueBoundary = $this->createFatigueBoundary(23);

        $gridOfFatigue = new GridOfFatigue($this->createStamina(4));
Severity: Minor
Found in tests/Stamina/GridOfFatigueTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_be_fatigued is not named in camelCase.
Open

    public function I_can_be_fatigued(): void
    {
        $fatigueBoundary = $this->createFatigueBoundary(5);
        $stamina = $this->createStaminaToTest($fatigueBoundary);
Severity: Minor
Found in tests/Stamina/StaminaTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_rest_so_little_so_nothing_changes is not named in camelCase.
Open

    public function I_can_rest_so_little_so_nothing_changes(): void
    {
        $fatigueBoundary = $this->createFatigueBoundary(4);
        $stamina = $this->createStaminaToTest($fatigueBoundary);
Severity: Minor
Found in tests/Stamina/StaminaTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language