Sign upLogin

jaroslavtyc/drd-plus-tables

View on GitHub
Star
src/Armaments/Weapons/WeaponsTable.php

Summary

Maintainability
A
1 hr
Test Coverage

Method addNewCustomWeapon has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addNewCustomWeapon(
        WeaponCode $weaponCode,
        WeaponCategoryCode $weaponCategoryCode,
        array $newWeaponParameters
    ): bool
Severity: Minor
Found in src/Armaments/Weapons/WeaponsTable.php - About 1 hr to fix

    Avoid using static access to class '\Granam\String\StringTools' in method 'addNewCustomWeapon'.
    Open

            $isType = StringTools::assembleIsForName(
            \rtrim(
                \str_replace(
                    ['knives', 's_and_', '_and_'], ['knife', '_or_', '_or_'],
                    $weaponCategoryCode->getValue()
    Severity: Minor
    Found in src/Armaments/Weapons/WeaponsTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Granam\String\StringTools' in method 'addNewCustomWeapon'.
    Open

            $getTypeCodes = StringTools::assembleGetterForName($weaponCategoryCode->getValue()) . 'Values';
    Severity: Minor
    Found in src/Armaments/Weapons/WeaponsTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status