Method getValueInDifferentUnit has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function getValueInDifferentUnit(string $toUnit): float
{
if ($this->getUnit() === $toUnit) {
return $this->getValue();
}Function getValueInDifferentUnit has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
private function getValueInDifferentUnit(string $toUnit): float
{
if ($this->getUnit() === $toUnit) {
return $this->getValue();
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return $this->getValue() * 1000;Avoid too many return statements within this method. Open
return $this->getValue() * 10;Avoid too many return statements within this method. Open
return $this->getValue() * 10000;The method getValueInDifferentUnit() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
private function getValueInDifferentUnit(string $toUnit): float
{
if ($this->getUnit() === $toUnit) {
return $this->getValue();
}- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'getValueInDifferentUnit'. Open
. ' to ' . ValueDescriber::describe($toUnit) . ' unit(s)'- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\DrdPlus\Codes\Units\DistanceUnitCode' in method 'getUnitCode'. Open
return DistanceUnitCode::getIt($this->getUnit());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'getValueInDifferentUnit'. Open
'Unknown one or both from ' . ValueDescriber::describe($this->getUnit())- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}