Sign upLogin

jaroslavtyc/drd-plus-tables

View on GitHub
Star
src/Partials/AbstractFileTable.php

Summary

Maintainability
C
1 day
Test Coverage

The class AbstractFileTable has an overall complexity of 77 which is very high. The configured complexity threshold is 50.
Open

abstract class AbstractFileTable extends AbstractTable
{
    protected const INTEGER = 'integer';
    protected const POSITIVE_INTEGER = 'positive_integer';
    protected const NEGATIVE_INTEGER = 'negative_integer';
Severity: Minor
Found in src/Partials/AbstractFileTable.php by phpmd

File AbstractFileTable.php has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types = 1);

namespace DrdPlus\Tables\Partials;

use Granam\Boolean\Tools\ToBoolean;
Severity: Minor
Found in src/Partials/AbstractFileTable.php - About 3 hrs to fix

    AbstractFileTable has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class AbstractFileTable extends AbstractTable
{
    protected const INTEGER = 'integer';
    protected const POSITIVE_INTEGER = 'positive_integer';
    protected const NEGATIVE_INTEGER = 'negative_integer';
    Severity: Minor
    Found in src/Partials/AbstractFileTable.php - About 2 hrs to fix

      Function parseRowsHeader has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function parseRowsHeader(array $data): array
    {
        $rowsHeaderNamesRow = $this->parseRowsHeaderNames($data);
        if ($rowsHeaderNamesRow === []) {
            return [];
      Severity: Minor
      Found in src/Partials/AbstractFileTable.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getRowHeadersUsedAsColumnHeaderAsWell has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getRowHeadersUsedAsColumnHeaderAsWell(): array
    {
        $rowHeadersUsedAsColumnHeaderAsWell = [];
        foreach ($this->getRowsHeader() as $rowHeader) {
            foreach ($this->getNormalizedExpectedColumnsHeader() as $expectedColumnIndex) {
      Severity: Minor
      Found in src/Partials/AbstractFileTable.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return array_map(
                    fn(string $item) => trim($item),
                    $value !== ''
                        ? explode(';', $value)
                        : []
      Severity: Major
      Found in src/Partials/AbstractFileTable.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return self::ARRAY;
        Severity: Major
        Found in src/Partials/AbstractFileTable.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return self::FLOAT;
          Severity: Major
          Found in src/Partials/AbstractFileTable.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $value === '' ? false : ToFloat::toFloat($this->normalizeMinus($value));
            Severity: Major
            Found in src/Partials/AbstractFileTable.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $value;
              Severity: Major
              Found in src/Partials/AbstractFileTable.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return self::STRING;
                Severity: Major
                Found in src/Partials/AbstractFileTable.php - About 30 mins to fix

                  Function cutOffRowsHeader has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function cutOffRowsHeader(array $values): array
    {
        $rowHeadersUsedAsColumnHeaderAsWell = $this->getRowHeadersUsedAsColumnHeaderAsWell();
        $rowIndexes = array_keys($values);
        foreach ($rowIndexes as $rowIndex) {
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  The method normalizeValueForType() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                  Open

                      private function normalizeValueForType($value, string $type)
    {
        $value = trim($value);
        switch ($type) {
            case self::BOOLEAN :
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  CyclomaticComplexity

                  Since: 0.1

                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                  Example

                  // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                  Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'checkHeaderValue'.
                  Open

                                  . ', got ' . ValueDescriber::describe($rawData[0][$columnIndex])
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'checkHeaderValue'.
                  Open

                                  "Missing header cell [$columnIndex] with expected value " . ValueDescriber::describe($expectedHeaderValue)
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'getColumnType'.
                  Open

                                  'Given column index ' . ValueDescriber::describe($columnIndex) . ' does not exists in header indexes '
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  Avoid using static access to class '\Granam\Float\Tools\ToFloat' in method 'normalizeValueForType'.
                  Open

                                  return $value === '' ? false : ToFloat::toFloat($this->normalizeMinus($value));
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  Avoid using static access to class '\Granam\Integer\Tools\ToInteger' in method 'normalizeValueForType'.
                  Open

                                  return $value === '' ? false : ToInteger::toInteger($this->normalizeMinus($value));
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  Avoid using static access to class '\Granam\Integer\Tools\ToInteger' in method 'normalizeValueForType'.
                  Open

                                  return $value === '' ? false : ToInteger::toPositiveInteger($this->normalizeMinus($value));
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'normalizeType'.
                  Open

                                      'Unknown type ' . ValueDescriber::describe($type)
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  The method indexByRowsHeader uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                              } else {
                $indexed[$keyPart] = $this->indexByRowsHeader($toIndex, $keyPartsOrRowIndex);
            }
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  Avoid using static access to class '\Granam\Boolean\Tools\ToBoolean' in method 'normalizeValueForType'.
                  Open

                                  return ToBoolean::toBoolean($value, false /* not strict */);
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  The method indexByColumnsHeader uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                              } else {
                $indexed[$rowKeyOrColumnIndex] = $this->indexByColumnsHeader($rowOrFinalValue, $columnKeys, $stepsToBottom - 1);
            }
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  Avoid using static access to class '\Granam\Integer\Tools\ToInteger' in method 'normalizeValueForType'.
                  Open

                                  return $value === '' ? false : ToInteger::toNegativeInteger($this->normalizeMinus($value));
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  Avoid excessively long variable names like $expectedDataHeaderNamesToTypes. Keep variable name length under 20.
                  Open

                              $expectedDataHeaderNamesToTypes = $this->getExpectedDataHeaderNamesToTypes();
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $valuesWithoutColumnsHeader. Keep variable name length under 20.
                  Open

                          $valuesWithoutColumnsHeader = $this->cutOffColumnsHeader($rawData);
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $expectedColumnsHeader. Keep variable name length under 20.
                  Open

                          $expectedColumnsHeader = $this->getNormalizedExpectedColumnsHeader(); // the very first rows of data
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $expectedColumnIndexes. Keep variable name length under 20.
                  Open

                          $expectedColumnIndexes = array_keys($expectedColumnsHeader);
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $rowHeadersUsedAsColumnHeaderAsWell. Keep variable name length under 20.
                  Open

                          $rowHeadersUsedAsColumnHeaderAsWell = [];
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $normalizedExpectedColumnHeader. Keep variable name length under 20.
                  Open

                      private ?array $normalizedExpectedColumnHeader = null;
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $rowHeadersUsedAsColumnHeaderAsWell. Keep variable name length under 20.
                  Open

                          $rowHeadersUsedAsColumnHeaderAsWell = $this->getRowHeadersUsedAsColumnHeaderAsWell();
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $columnIndexOfRowHeader. Keep variable name length under 20.
                  Open

                              foreach ($this->getRowsHeader() as $columnIndexOfRowHeader => $rowHeaderName) {
                  Severity: Minor
                  Found in src/Partials/AbstractFileTable.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  There are no issues that match your filters.

                  Category
                  Status