Sign upLogin

jaroslavtyc/drd-plus-tables

View on GitHub
Star
src/Partials/AbstractTable.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function createHeader has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private function createHeader(): array
    {
        $rowsHeader = $this->toFlatStructure($this->getRowsHeader());
        $columnsHeader = $this->toFlatStructure($this->getColumnsHeader());
        $rowsHeaderRowCount = \count(\current($rowsHeader));
Severity: Minor
Found in src/Partials/AbstractTable.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toFlatStructure has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function toFlatStructure(array $values, bool $convertTopKeysToValues = false): array
    {
        $inFlatStructure = [];
        foreach ($values as $key => $wrappedValues) {
            if (!\is_array($wrappedValues)) {
Severity: Minor
Found in src/Partials/AbstractTable.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createHeader has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function createHeader(): array
    {
        $rowsHeader = $this->toFlatStructure($this->getRowsHeader());
        $columnsHeader = $this->toFlatStructure($this->getColumnsHeader());
        $rowsHeaderRowCount = \count(\current($rowsHeader));
Severity: Minor
Found in src/Partials/AbstractTable.php - About 1 hr to fix

    Function findRow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function findRow($singleRowIndexes): ?array
    {
        $arraySingleRowIndexes = \is_array($singleRowIndexes)
            ? $singleRowIndexes
            : [$singleRowIndexes];
    Severity: Minor
    Found in src/Partials/AbstractTable.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method toFlatStructure has a boolean flag argument $convertTopKeysToValues, which is a certain sign of a Single Responsibility Principle violation.
    Open

        private function toFlatStructure(array $values, bool $convertTopKeysToValues = false): array
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method createHeader uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                foreach ($columnsHeader as $columnsHeaderColumn) {
                    $headerRowFromColumnsHeader[] = $columnsHeaderColumn[$columnsHeaderRowIndex];
                }
            }
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\Granam\Scalar\Tools\ToString' in method 'getValueInRow'.
    Open

            $stringColumnIndex = ToString::toString($columnIndex);
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method toFlatStructure uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $rows = $this->toFlatStructure($wrappedValues, $convertTopKeysToValues);
            }
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'getValueInRow'.
    Open

                    'Column of name ' . ValueDescriber::describe($columnIndex) . ' does not exist'
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'getRow'.
    Open

                    'Row has not been found by index(es) "' . ValueDescriber::describe($singleRowIndexes) . '"'
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Granam\Scalar\Tools\ToString' in method 'findRow'.
    Open

                $stringRowIndex = ToString::toString($rowIndex);
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method createHeader uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                foreach ($rowsHeader as $columnsHeaderColumn) {
                    $headerRowFromRowsHeader[] = $columnsHeaderColumn[$rowsHeaderRowIndex];
                }
            }
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid excessively long variable names like $headerRowFromColumnsHeader. Keep variable name length under 20.
    Open

                $headerRowFromColumnsHeader = [];
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $arraySingleRowIndexes. Keep variable name length under 20.
    Open

            $arraySingleRowIndexes = \is_array($singleRowIndexes)
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $columnsHeaderRowCount. Keep variable name length under 20.
    Open

            $columnsHeaderRowCount = \count(\current($columnsHeader));
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $convertTopKeysToValues. Keep variable name length under 20.
    Open

        private function toFlatStructure(array $values, bool $convertTopKeysToValues = false): array
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $headerInFlatStructure. Keep variable name length under 20.
    Open

        private ?array $headerInFlatStructure = null;
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $columnsHeaderIndexShift. Keep variable name length under 20.
    Open

            $columnsHeaderIndexShift = $columnsHeaderRowCount - $maxRowsCount;
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $headerRowFromRowsHeader. Keep variable name length under 20.
    Open

                $headerRowFromRowsHeader = [];
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $columnsHeaderRowIndex. Keep variable name length under 20.
    Open

                $columnsHeaderRowIndex = $rowIndex + $columnsHeaderIndexShift;
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $valuesInFlatStructure. Keep variable name length under 20.
    Open

        private ?array $valuesInFlatStructure = null;
    Severity: Minor
    Found in src/Partials/AbstractTable.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status