File Tables.php
has 937 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php declare(strict_types=1);
namespace DrdPlus\Tables;
use DrdPlus\Codes\Armaments\ArmamentCode;
Tables
has 96 functions (exceeds 20 allowed). Consider refactoring. Open
class Tables extends StrictObject implements \IteratorAggregate
{
private static ?Tables $tablesInstance = null;
public static function getIt(): Tables
The class Tables has an overall complexity of 213 which is very high. The configured complexity threshold is 50. Open
class Tables extends StrictObject implements \IteratorAggregate
{
private static ?Tables $tablesInstance = null;
public static function getIt(): Tables
- Exclude checks
Method getIterator
has 83 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getIterator(): \ArrayObject
{
return new \ArrayObject([
$this->getAmountTable(),
$this->getSkillsByBackgroundPointsTable(),
The class Tables has 95 public methods and attributes. Consider reducing the number of public items to less than 45. Open
class Tables extends StrictObject implements \IteratorAggregate
{
private static ?Tables $tablesInstance = null;
public static function getIt(): Tables
- Read upRead up
- Exclude checks
ExcessivePublicCount
Since: 0.1
A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it.
Example
public class Foo {
public $value;
public $something;
public $var;
// [... more more public attributes ...]
public function doWork() {}
public function doMoreWork() {}
public function doWorkAgain() {}
// [... more more public methods ...]
}
Source https://phpmd.org/rules/codesize.html#excessivepubliccount
Method getMeleeWeaponsTableByMeleeWeaponCode
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getMeleeWeaponsTableByMeleeWeaponCode(MeleeWeaponCode $meleeWeaponCode): MeleeWeaponsTable
{
if ($meleeWeaponCode->isAxe()) {
return $this->getAxesTable();
}
Function getMeleeWeaponsTableByMeleeWeaponCode
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function getMeleeWeaponsTableByMeleeWeaponCode(MeleeWeaponCode $meleeWeaponCode): MeleeWeaponsTable
{
if ($meleeWeaponCode->isAxe()) {
return $this->getAxesTable();
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return $this->getSwordsTable();
Avoid too many return
statements within this method. Open
return $this->getSabersAndBowieKnivesTable();
Avoid too many return
statements within this method. Open
return $this->getStaffsAndSpearsTable();
Avoid too many return
statements within this method. Open
return $this->getUnarmedTable();
Avoid too many return
statements within this method. Open
return $this->getVoulgesAndTridentsTable();
The method getMeleeWeaponsTableByMeleeWeaponCode() has an NPath complexity of 512. The configured NPath complexity threshold is 200. Open
public function getMeleeWeaponsTableByMeleeWeaponCode(MeleeWeaponCode $meleeWeaponCode): MeleeWeaponsTable
{
if ($meleeWeaponCode->isAxe()) {
return $this->getAxesTable();
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getMeleeWeaponsTableByMeleeWeaponCode() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
public function getMeleeWeaponsTableByMeleeWeaponCode(MeleeWeaponCode $meleeWeaponCode): MeleeWeaponsTable
{
if ($meleeWeaponCode->isAxe()) {
return $this->getAxesTable();
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class Tables has a coupling between objects value of 110. Consider to reduce the number of dependencies under 13. Open
class Tables extends StrictObject implements \IteratorAggregate
{
private static ?Tables $tablesInstance = null;
public static function getIt(): Tables
- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Missing class import via use statement (line '741', column '20'). Open
return new \ArrayObject([
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid excessively long variable names like $protectiveArmamentCode. Keep variable name length under 20. Open
public function getProtectiveArmamentsTable(ProtectiveArmamentCode $protectiveArmamentCode): UnwieldyTable
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $protectiveArmamentCode. Keep variable name length under 20. Open
public function getProtectiveArmamentMissingSkillTableByCode(ProtectiveArmamentCode $protectiveArmamentCode): MissingProtectiveArmamentSkill
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}