Sign upLogin

jaroslavtyc/drd-plus-tables

View on GitHub
Star
src/Theurgist/Demons/Demon.php

Summary

Maintainability
D
1 day
Test Coverage

Demon has 58 functions (exceeds 20 allowed). Consider refactoring.
Open

class Demon extends StrictObject
{
    use SanitizeMutableParameterChangesTrait;

    private \DrdPlus\Codes\Theurgist\DemonCode $demonCode;
Severity: Major
Found in src/Theurgist/Demons/Demon.php - About 1 day to fix

    File Demon.php has 416 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php declare(strict_types=1);

namespace DrdPlus\Tables\Theurgist\Demons;

use DrdPlus\Codes\Theurgist\DemonBodyCode;
    Severity: Minor
    Found in src/Theurgist/Demons/Demon.php - About 6 hrs to fix

      The class Demon has an overall complexity of 86 which is very high. The configured complexity threshold is 50.
      Open

      class Demon extends StrictObject
{
    use SanitizeMutableParameterChangesTrait;

    private \DrdPlus\Codes\Theurgist\DemonCode $demonCode;
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      The class Demon has a coupling between objects value of 33. Consider to reduce the number of dependencies under 13.
      Open

      class Demon extends StrictObject
{
    use SanitizeMutableParameterChangesTrait;

    private \DrdPlus\Codes\Theurgist\DemonCode $demonCode;
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Avoid using static access to class '\DrdPlus\Codes\Theurgist\DemonMutableParameterCode' in method 'sanitizeDemonParameterChanges'.
      Open

                      DemonMutableParameterCode::getPossibleValues(),
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'checkDemonTraits'.
      Open

                          'Expected instance of ' . DemonTrait::class . ', got ' . ValueDescriber::describe($demonTrait)
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid excessively long variable names like $realmsIncrementBecauseOfDifficulty. Keep variable name length under 20.
      Open

              $realmsIncrementBecauseOfDifficulty = $this->getCurrentDifficulty()->getCurrentRealmsIncrement();
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $baseDemonInvisibility. Keep variable name length under 20.
      Open

              $baseDemonInvisibility = $this->getBaseDemonInvisibility();
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $parametersDifficultyChangeSum. Keep variable name length under 20.
      Open

              $parametersDifficultyChangeSum = 0;
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $demonParameterChanges. Keep variable name length under 20.
      Open

          private function sanitizeDemonParameterChanges(array $demonParameterChanges): array
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $demonParameterChanges. Keep variable name length under 20.
      Open

              array $demonParameterChanges,
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $invalidValueForMutableParameter. Keep variable name length under 20.
      Open

              } catch (InvalidValueForMutableParameter $invalidValueForMutableParameter) {
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $demonParameterChanges. Keep variable name length under 20.
      Open

          private array $demonParameterChanges;
      Severity: Minor
      Found in src/Theurgist/Demons/Demon.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      There are no issues that match your filters.

      Category
      Status