Sign upLogin

jaroslavtyc/drd-plus-tables

View on GitHub
Star
src/Theurgist/Spells/Formula.php

Summary

Maintainability
D
2 days
Test Coverage

File Formula.php has 459 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types = 1);

namespace DrdPlus\Tables\Theurgist\Spells;

use DrdPlus\Codes\Units\DistanceUnitCode;
Severity: Minor
Found in src/Theurgist/Spells/Formula.php - About 7 hrs to fix

    Formula has 46 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Formula extends StrictObject
{
    use ToFlatArrayTrait;
    use SanitizeMutableParameterChangesTrait;
    Severity: Minor
    Found in src/Theurgist/Spells/Formula.php - About 6 hrs to fix

      The class Formula has an overall complexity of 89 which is very high. The configured complexity threshold is 50.
      Open

      class Formula extends StrictObject
{
    use ToFlatArrayTrait;
    use SanitizeMutableParameterChangesTrait;
      Severity: Minor
      Found in src/Theurgist/Spells/Formula.php by phpmd

      Function getParameterBonusFromModifiers has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getParameterBonusFromModifiers(string $parameterName)
    {
        $bonusParts = [];
        foreach ($this->modifiers as $modifier) {
            if ($modifier->getModifierCode()->getValue() === ModifierCode::GATE) {
      Severity: Minor
      Found in src/Theurgist/Spells/Formula.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getParameterBonusFromModifiers has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getParameterBonusFromModifiers(string $parameterName)
    {
        $bonusParts = [];
        foreach ($this->modifiers as $modifier) {
            if ($modifier->getModifierCode()->getValue() === ModifierCode::GATE) {
      Severity: Minor
      Found in src/Theurgist/Spells/Formula.php - About 1 hr to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                FormulaCode $formulaCode,
        Tables $tables,
        array $formulaSpellParameterValues,
        array $modifiers,
        array $formulaSpellTraits
        Severity: Minor
        Found in src/Theurgist/Spells/Formula.php - About 35 mins to fix

          The class Formula has a coupling between objects value of 35. Consider to reduce the number of dependencies under 13.
          Open

          class Formula extends StrictObject
{
    use ToFlatArrayTrait;
    use SanitizeMutableParameterChangesTrait;
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          CouplingBetweenObjects

          Since: 1.1.0

          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

          Example

          class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

          Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'getCurrentSpellAttack'.
          Open

                      Tables::getIt()
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Granam\String\StringTools' in method 'getParameterBonusFromModifiers'.
          Open

                      $getParameterWithAddition = StringTools::assembleGetterForName($parameterName . 'WithAddition');
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'getCheckedSpellTraits'.
          Open

                              'Expected instance of ' . SpellTrait::class . ', got ' . ValueDescriber::describe($spellTrait)
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Granam\Tools\ValueDescriber' in method 'getCheckedModifiers'.
          Open

                              'Expected instance of ' . Modifier::class . ', got ' . ValueDescriber::describe($modifier)
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\DrdPlus\Codes\Theurgist\FormulaMutableParameterCode' in method 'sanitizeSpellParameterChanges'.
          Open

                          FormulaMutableParameterCode::getPossibleValues(),
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'getCurrentSpellPower'.
          Open

                      Tables::getIt()
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private function sanitizeSpellParameterChanges(array $spellParameterValues): array
    {
        try {
            return $this->sanitizeMutableParameterChanges(
                $spellParameterValues,
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php and 1 other location - About 55 mins to fix
          src/Theurgist/Spells/Modifier.php on lines 75..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 99.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid excessively long variable names like $epicenterShiftWithAddition. Keep variable name length under 20.
          Open

                  $epicenterShiftWithAddition = $this->getEpicenterShiftWithAddition();
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $invalidValueForMutableParameter. Keep variable name length under 20.
          Open

                  } catch (InvalidValueForMutableParameter $invalidValueForMutableParameter) {
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $realmsIncrementBecauseOfDifficulty. Keep variable name length under 20.
          Open

                  $realmsIncrementBecauseOfDifficulty = $this->getCurrentDifficulty()->getCurrentRealmsIncrement();
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $radiusModifiersChange. Keep variable name length under 20.
          Open

                  $radiusModifiersChange = $this->getParameterBonusFromModifiers(ModifierMutableParameterCode::SPELL_RADIUS);
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $modifierRealmsAffectionPeriod. Keep variable name length under 20.
          Open

                      $modifierRealmsAffectionPeriod = $modifierRealmsAffection->getAffectionPeriodCode()->getValue();
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $epicenterShiftByModifiers. Keep variable name length under 20.
          Open

                  $epicenterShiftByModifiers = $this->getParameterBonusFromModifiers(ModifierMutableParameterCode::EPICENTER_SHIFT);
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $formulaSpellParameterChanges. Keep variable name length under 20.
          Open

              private array $formulaSpellParameterChanges;
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $modifierRealmsAffection. Keep variable name length under 20.
          Open

                      $modifierRealmsAffection = $modifier->getRealmsAffection();
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $byModifierRequiredRealm. Keep variable name length under 20.
          Open

                      $byModifierRequiredRealm = $modifier->getRequiredRealm();
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $spellAttackWithAddition. Keep variable name length under 20.
          Open

                  $spellAttackWithAddition = $this->getSpellAttackWithAddition();
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $formulaSpellParameterValues. Keep variable name length under 20.
          Open

                  array $formulaSpellParameterValues,
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $spellTraitsDifficultyChangeSum. Keep variable name length under 20.
          Open

                  $spellTraitsDifficultyChangeSum = 0;
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $spellPowerWithAddition. Keep variable name length under 20.
          Open

                  $spellPowerWithAddition = $this->getSpellPowerWithAddition();
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $spellSpeedWithAddition. Keep variable name length under 20.
          Open

                  $spellSpeedWithAddition = $this->getSpellSpeedWithAddition();
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $parametersDifficultyChangeSum. Keep variable name length under 20.
          Open

                  $parametersDifficultyChangeSum = 0;
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $modifiersDifficultyChangeSum. Keep variable name length under 20.
          Open

                  $modifiersDifficultyChangeSum = 0;
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Avoid excessively long variable names like $getParameterWithAddition. Keep variable name length under 20.
          Open

                      $getParameterWithAddition = StringTools::assembleGetterForName($parameterName . 'WithAddition');
          Severity: Minor
          Found in src/Theurgist/Spells/Formula.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          There are no issues that match your filters.

          Category
          Status