jaroslavtyc/drd-plus-tables

Method provideArmamentAndNameWithValue has 56 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function provideArmamentAndNameWithValue(): array
    {
        return [
            [ShieldCode::WITHOUT_SHIELD, ShieldsTable::REQUIRED_STRENGTH, false],
            [ShieldCode::WITHOUT_SHIELD, ShieldsTable::LENGTH, 0],

Method I_get_same_values_without_shield_as_without_weapon has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function I_get_same_values_without_shield_as_without_weapon()
    {
        $shieldsTable = new ShieldsTable();
        $unarmedTable = new UnarmedTable();
        self::assertFalse($shieldsTable->getRequiredStrengthOf(ShieldCode::WITHOUT_SHIELD));

The method I_get_same_values_without_shield_as_without_weapon is not named in camelCase.

Open

    public function I_get_same_values_without_shield_as_without_weapon()
    {
        $shieldsTable = new ShieldsTable();
        $unarmedTable = new UnarmedTable();
        self::assertFalse($shieldsTable->getRequiredStrengthOf(ShieldCode::WITHOUT_SHIELD));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method I_can_not_get_value_of_unknown_shield is not named in camelCase.

Open

    public function I_can_not_get_value_of_unknown_shield($valueName)
    {
        $this->expectException(\DrdPlus\Tables\Armaments\Exceptions\UnknownShield::class);
        $this->expectExceptionMessageMatches('~protector_of_masses~');
        $getValueNameOf = $this->assembleValueGetter($valueName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}