Function scanForDemonClasses
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
private function scanForDemonClasses(string $rootDir, string $rootNamespace): array
{
$demonClasses = [];
foreach (scandir($rootDir, SCANDIR_SORT_NONE) as $folder) {
$folderFullPath = $rootDir . DIRECTORY_SEPARATOR . $folder;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method scanForDemonClasses
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function scanForDemonClasses(string $rootDir, string $rootNamespace): array
{
$demonClasses = [];
foreach (scandir($rootDir, SCANDIR_SORT_NONE) as $folder) {
$folderFullPath = $rootDir . DIRECTORY_SEPARATOR . $folder;
The method scanForDemonClasses() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
private function scanForDemonClasses(string $rootDir, string $rootNamespace): array
{
$demonClasses = [];
foreach (scandir($rootDir, SCANDIR_SORT_NONE) as $folder) {
$folderFullPath = $rootDir . DIRECTORY_SEPARATOR . $folder;
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '30', column '31'). Open
$codeReflection = new \ReflectionClass($rootClass);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '57', column '44'). Open
$reflectionClass = new \ReflectionClass($className);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method Every_demon_parameter_class_has_its_test is not named in camelCase. Open
public function Every_demon_parameter_class_has_its_test()
{
foreach ($this->getDemonParameterClasses() as $demonParameterClass) {
$expectedTestClass = str_replace('DrdPlus\\', 'DrdPlus\\Tests\\', $demonParameterClass) . 'Test';
self::assertTrue(class_exists($expectedTestClass), "Missing test for $demonParameterClass, expected $expectedTestClass");
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}