jaroslavtyc/drd-plus-tables

View on GitHub
tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php

Summary

Maintainability
B
5 hrs
Test Coverage

Avoid using static access to class '\DrdPlus\Codes\Properties\PropertyCode' in method 'I_can_not_change_initial_addition'.
Open

        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::AGILITY));

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'I_can_get_its_clone_changed_by_addition'.
Open

        $original = new Trap(['123', '456=789', PropertyCode::ENDURANCE], Tables::getIt());

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'I_can_create_it_negative'.
Open

        $trap = new Trap(['-456', '4=6', PropertyCode::INTELLIGENCE], Tables::getIt());

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'I_can_not_create_it_with_unknown_property'.
Open

        new Trap(['35689', '332211', 'goodness'], Tables::getIt());

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Properties\PropertyCode' in method 'I_can_create_it_negative'.
Open

        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::INTELLIGENCE));

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'I_can_create_it_positive'.
Open

        $trap = new Trap(['35689', '332211', PropertyCode::ENDURANCE], Tables::getIt());

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'I_can_not_change_initial_addition'.
Open

        $trap = new Trap(['1', '2', PropertyCode::AGILITY], Tables::getIt());

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Properties\PropertyCode' in method 'I_can_create_it_positive'.
Open

        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::ENDURANCE));

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'I_can_create_it_with_zero'.
Open

        $trap = new Trap(['0', '78=321', PropertyCode::CHARISMA], Tables::getIt());

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Codes\Properties\PropertyCode' in method 'I_can_create_it_with_zero'.
Open

        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::CHARISMA));

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DrdPlus\Tables\Tables' in method 'I_can_not_create_it_without_property'.
Open

        new Trap(['35689', '332211'], Tables::getIt());

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function I_can_not_change_initial_addition()
    {
        $trap = new Trap(['1', '2', PropertyCode::AGILITY], Tables::getIt());
        self::assertSame(1, $trap->getValue());
        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::AGILITY));
Severity: Major
Found in tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php and 2 other locations - About 1 hr to fix
tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php on lines 23..30
tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php on lines 32..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function I_can_create_it_with_zero(): void
    {
        $trap = new Trap(['0', '78=321', PropertyCode::CHARISMA], Tables::getIt());
        self::assertSame(0, $trap->getValue());
        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::CHARISMA));
Severity: Major
Found in tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php and 2 other locations - About 1 hr to fix
tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php on lines 32..39
tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php on lines 41..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function I_can_create_it_positive(): void
    {
        $trap = new Trap(['35689', '332211', PropertyCode::ENDURANCE], Tables::getIt());
        self::assertSame(35689, $trap->getValue());
        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::ENDURANCE));
Severity: Major
Found in tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php and 2 other locations - About 1 hr to fix
tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php on lines 23..30
tests/Tables/Theurgist/Spells/SpellParameters/TrapTest.php on lines 41..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The method I_can_create_it_positive is not named in camelCase.
Open

    protected function I_can_create_it_positive(): void
    {
        $trap = new Trap(['35689', '332211', PropertyCode::ENDURANCE], Tables::getIt());
        self::assertSame(35689, $trap->getValue());
        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::ENDURANCE));

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_it_without_property is not named in camelCase.
Open

    public function I_can_not_create_it_without_property(): void
    {
        $this->expectException(\DrdPlus\Tables\Theurgist\Spells\SpellParameters\Exceptions\InvalidFormatOfPropertyUsedForTrap::class);
        $this->expectExceptionMessageMatches('~nothing~');
        new Trap(['35689', '332211'], Tables::getIt());

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_it_with_zero is not named in camelCase.
Open

    protected function I_can_create_it_with_zero(): void
    {
        $trap = new Trap(['0', '78=321', PropertyCode::CHARISMA], Tables::getIt());
        self::assertSame(0, $trap->getValue());
        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::CHARISMA));

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_its_clone_changed_by_addition is not named in camelCase.
Open

    public function I_can_get_its_clone_changed_by_addition(): void
    {
        $original = new Trap(['123', '456=789', PropertyCode::ENDURANCE], Tables::getIt());
        self::assertSame($original, $original->getWithAddition(0));
        $increased = $original->getWithAddition(456);

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_change_initial_addition is not named in camelCase.
Open

    protected function I_can_not_change_initial_addition()
    {
        $trap = new Trap(['1', '2', PropertyCode::AGILITY], Tables::getIt());
        self::assertSame(1, $trap->getValue());
        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::AGILITY));

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_it_negative is not named in camelCase.
Open

    protected function I_can_create_it_negative(): void
    {
        $trap = new Trap(['-456', '4=6', PropertyCode::INTELLIGENCE], Tables::getIt());
        self::assertSame(-456, $trap->getValue());
        self::assertSame($trap->getPropertyCode(), PropertyCode::getIt(PropertyCode::INTELLIGENCE));

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_it_with_unknown_property is not named in camelCase.
Open

    public function I_can_not_create_it_with_unknown_property(): void
    {
        $this->expectException(\DrdPlus\Tables\Theurgist\Spells\SpellParameters\Exceptions\InvalidFormatOfPropertyUsedForTrap::class);
        $this->expectExceptionMessageMatches('~goodness~');
        new Trap(['35689', '332211', 'goodness'], Tables::getIt());

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status