jaroslavtyc/granam-gpwebpay

View on GitHub

Showing 22 of 26 total issues

File CardPayRequestValues.php has 495 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

namespace Granam\GpWebPay;

use Granam\Boolean\Tools\ToBoolean;
Severity: Minor
Found in GpWebPay/CardPayRequestValues.php - About 7 hrs to fix

    CardPayRequestValues has 37 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class CardPayRequestValues extends StrictObject
    {
    
        // name => is required
        private static array $keysExpectedInArray = [
    Severity: Minor
    Found in GpWebPay/CardPayRequestValues.php - About 4 hrs to fix

      Function normalizeValues has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function normalizeValues(array $withUpperCasedKeys): array
          {
              $normalizedValues = [];
              foreach (self::$keysExpectedInArray as $key => $required) {
                  if (($withUpperCasedKeys[$key] ?? null) === null) {
      Severity: Minor
      Found in GpWebPay/CardPayRequestValues.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 16 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              CurrencyCodes $currencyCodes,
              int $orderNumber,
              float $price,
              int $currencyNumericCode,
              bool $depositFlag, // false = instant payment not required, true = requires immediate payment
      Severity: Major
      Found in GpWebPay/CardPayRequestValues.php - About 2 hrs to fix

        Method sanitizeAsciiRange has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function sanitizeAsciiRange(
                string $value,
                string $nameOfParameter,
                array $characterRanges = [[' ' /* 0x20 = space */, '~' /* 0x7E = tilde */]]
            ): string
        Severity: Minor
        Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

          Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  SettingsInterface $settings,
                  DigestSignerInterface $digestSigner,
                  string $operation,
                  int $orderNumber,
                  int $prCode,
          Severity: Major
          Found in GpWebPay/CardPayResponse.php - About 1 hr to fix

            Method buildParametersForDigest has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function buildParametersForDigest(CardPayRequestValues $requestValues, SettingsInterface $settings): array
                {
                    $parametersWithoutDigest = [];
                    // parameters HAVE TO be in this order, see GP_webpay_HTTP_EN.pdf / GP_webpay_HTTP.pdf
                    $parametersWithoutDigest[RequestDigestKeys::MERCHANTNUMBER] = $settings->getMerchantNumber();
            Severity: Minor
            Found in GpWebPay/CardPayRequest.php - About 1 hr to fix

              Method normalizeValues has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private static function normalizeValues(array $withUpperCasedKeys): array
                  {
                      $normalizedValues = [];
                      foreach (self::$keysExpectedInArray as $key => $required) {
                          if (($withUpperCasedKeys[$key] ?? null) === null) {
              Severity: Minor
              Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

                Method setPayMethods has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function setPayMethods(array $payMethods = null)
                    {
                        if ($payMethods === null) {
                            return;
                        }
                Severity: Minor
                Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

                  Method createFromArray has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function createFromArray(array $valuesFromGetOrPost, CurrencyCodes $currencyCodes): CardPayRequestValues
                      {
                          $withUpperCasedKeys = [];
                          foreach ($valuesFromGetOrPost as $key => $value) {
                              $withUpperCasedKeys[\strtoupper(\trim($key))] = $value;
                  Severity: Minor
                  Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

                    Method __construct has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function __construct(
                            SettingsInterface $settings,
                            DigestSignerInterface $digestSigner,
                            string $operation,
                            int $orderNumber,
                    Severity: Minor
                    Found in GpWebPay/CardPayResponse.php - About 1 hr to fix

                      Function normalizeValues has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected static function normalizeValues(array $values): array
                          {
                              $normalizedValues = [];
                              foreach (self::$expectedKeys as $key => $required) {
                                  $values[$key] ??= null;
                      Severity: Minor
                      Found in GpWebPay/CardPayResponse.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function buildParametersForDigest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function buildParametersForDigest(CardPayRequestValues $requestValues, SettingsInterface $settings): array
                          {
                              $parametersWithoutDigest = [];
                              // parameters HAVE TO be in this order, see GP_webpay_HTTP_EN.pdf / GP_webpay_HTTP.pdf
                              $parametersWithoutDigest[RequestDigestKeys::MERCHANTNUMBER] = $settings->getMerchantNumber();
                      Severity: Minor
                      Found in GpWebPay/CardPayRequest.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method getCurrentRequestUrl has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function getCurrentRequestUrl(): string
                          {
                              $protocol = 'http';
                              if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO'])) {
                                  $protocol = $_SERVER['HTTP_X_FORWARDED_PROTO'];
                      Severity: Minor
                      Found in GpWebPay/Settings.php - About 1 hr to fix

                        Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function __construct(
                                SettingsInterface $settings,
                                DigestSignerInterface $digestSigner,
                                string $operation,
                                int $orderNumber,
                        Severity: Minor
                        Found in GpWebPay/CardPayResponse.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                string $baseUrlForRequest,
                                string $privateKeyFile,
                                string $privateKeyPassword,
                                string $publicKeyFile,
                                string $merchantNumber,
                        Severity: Minor
                        Found in GpWebPay/Settings.php - About 45 mins to fix

                          Function getCurrentRequestUrl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              private function getCurrentRequestUrl(): string
                              {
                                  $protocol = 'http';
                                  if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO'])) {
                                      $protocol = $_SERVER['HTTP_X_FORWARDED_PROTO'];
                          Severity: Minor
                          Found in GpWebPay/Settings.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  int $prCode,
                                  int $srCode,
                                  string $resultText = null,
                                  $exceptionCode = null, // intentionally without scalar type hint
                                  \Exception $previousException = null
                          Severity: Minor
                          Found in GpWebPay/Exceptions/GpWebPayErrorResponse.php - About 35 mins to fix

                            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    int $prCode,
                                    int $srCode,
                                    string $resultText = null,
                                    $exceptionCode = null, // intentionally without scalar type hint
                                    \Exception $previousException = null
                            Severity: Minor
                            Found in GpWebPay/Exceptions/GpWebPayErrorByCustomerResponse.php - About 35 mins to fix

                              Method createForTest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      string $privateKeyFile,
                                      string $privateKeyPassword,
                                      string $publicKeyFile,
                                      string $merchantNumber,
                                      string $urlForResponse = null
                              Severity: Minor
                              Found in GpWebPay/Settings.php - About 35 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language