Sign upLogin

jaroslavtyc/granam-gpwebpay

View on GitHub
Star

Showing 26 of 26 total issues

File CardPayRequestValues.php has 495 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

namespace Granam\GpWebPay;

use Granam\Boolean\Tools\ToBoolean;
Severity: Minor
Found in GpWebPay/CardPayRequestValues.php - About 7 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            LanguageCodes::CS => [
            self::GENERIC_PROBLEM => 'Technický problém v GP webpay systému, kontaktujte obchodníka',
            self::OK_CODE => 'OK',
            self::FIELD_IS_TOO_LONG => 'Pole příliš dlouhé',
            self::FIELD_IS_TOO_SHORT => 'Pole příliš krátké',
    Severity: Major
    Found in GpWebPay/Codes/PrCodes.php and 1 other location - About 5 hrs to fix
    GpWebPay/Codes/PrCodes.php on lines 67..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 201.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            LanguageCodes::EN => [
            self::GENERIC_PROBLEM => 'Technical problem in GP webpay system, contact the merchant',
            self::OK_CODE => 'OK',
            self::FIELD_IS_TOO_LONG => 'Field too long',
            self::FIELD_IS_TOO_SHORT => 'Field too short',
    Severity: Major
    Found in GpWebPay/Codes/PrCodes.php and 1 other location - About 5 hrs to fix
    GpWebPay/Codes/PrCodes.php on lines 38..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 201.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    CardPayRequestValues has 37 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class CardPayRequestValues extends StrictObject
{

    // name => is required
    private static array $keysExpectedInArray = [
    Severity: Minor
    Found in GpWebPay/CardPayRequestValues.php - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              LanguageCodes::EN => [
            0 => '',
            1 => 'ORDERNUMBER',
            2 => 'MERCHANTNUMBER',
            6 => 'AMOUNT',
      Severity: Major
      Found in GpWebPay/Codes/SrCodes.php and 1 other location - About 3 hrs to fix
      GpWebPay/Codes/SrCodes.php on lines 12..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 152.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              LanguageCodes::CS => [
            0 => '',
            1 => 'ORDERNUMBER',
            2 => 'MERCHANTNUMBER',
            6 => 'AMOUNT',
      Severity: Major
      Found in GpWebPay/Codes/SrCodes.php and 1 other location - About 3 hrs to fix
      GpWebPay/Codes/SrCodes.php on lines 42..71

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 152.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function normalizeValues has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function normalizeValues(array $withUpperCasedKeys): array
    {
        $normalizedValues = [];
        foreach (self::$keysExpectedInArray as $key => $required) {
            if (($withUpperCasedKeys[$key] ?? null) === null) {
      Severity: Minor
      Found in GpWebPay/CardPayRequestValues.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 16 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              CurrencyCodes $currencyCodes,
        int $orderNumber,
        float $price,
        int $currencyNumericCode,
        bool $depositFlag, // false = instant payment not required, true = requires immediate payment
      Severity: Major
      Found in GpWebPay/CardPayRequestValues.php - About 2 hrs to fix

        Method sanitizeAsciiRange has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function sanitizeAsciiRange(
        string $value,
        string $nameOfParameter,
        array $characterRanges = [[' ' /* 0x20 = space */, '~' /* 0x7E = tilde */]]
    ): string
        Severity: Minor
        Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

          Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  SettingsInterface $settings,
        DigestSignerInterface $digestSigner,
        string $operation,
        int $orderNumber,
        int $prCode,
          Severity: Major
          Found in GpWebPay/CardPayResponse.php - About 1 hr to fix

            Method buildParametersForDigest has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function buildParametersForDigest(CardPayRequestValues $requestValues, SettingsInterface $settings): array
    {
        $parametersWithoutDigest = [];
        // parameters HAVE TO be in this order, see GP_webpay_HTTP_EN.pdf / GP_webpay_HTTP.pdf
        $parametersWithoutDigest[RequestDigestKeys::MERCHANTNUMBER] = $settings->getMerchantNumber();
            Severity: Minor
            Found in GpWebPay/CardPayRequest.php - About 1 hr to fix

              Method normalizeValues has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private static function normalizeValues(array $withUpperCasedKeys): array
    {
        $normalizedValues = [];
        foreach (self::$keysExpectedInArray as $key => $required) {
            if (($withUpperCasedKeys[$key] ?? null) === null) {
              Severity: Minor
              Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

                Method __construct has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function __construct(
        SettingsInterface $settings,
        DigestSignerInterface $digestSigner,
        string $operation,
        int $orderNumber,
                Severity: Minor
                Found in GpWebPay/CardPayResponse.php - About 1 hr to fix

                  Method setPayMethods has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function setPayMethods(array $payMethods = null)
    {
        if ($payMethods === null) {
            return;
        }
                  Severity: Minor
                  Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

                    Method createFromArray has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function createFromArray(array $valuesFromGetOrPost, CurrencyCodes $currencyCodes): CardPayRequestValues
    {
        $withUpperCasedKeys = [];
        foreach ($valuesFromGetOrPost as $key => $value) {
            $withUpperCasedKeys[\strtoupper(\trim($key))] = $value;
                    Severity: Minor
                    Found in GpWebPay/CardPayRequestValues.php - About 1 hr to fix

                      Function normalizeValues has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected static function normalizeValues(array $values): array
    {
        $normalizedValues = [];
        foreach (self::$expectedKeys as $key => $required) {
            $values[$key] ??= null;
                      Severity: Minor
                      Found in GpWebPay/CardPayResponse.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function buildParametersForDigest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function buildParametersForDigest(CardPayRequestValues $requestValues, SettingsInterface $settings): array
    {
        $parametersWithoutDigest = [];
        // parameters HAVE TO be in this order, see GP_webpay_HTTP_EN.pdf / GP_webpay_HTTP.pdf
        $parametersWithoutDigest[RequestDigestKeys::MERCHANTNUMBER] = $settings->getMerchantNumber();
                      Severity: Minor
                      Found in GpWebPay/CardPayRequest.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method getCurrentRequestUrl has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function getCurrentRequestUrl(): string
    {
        $protocol = 'http';
        if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO'])) {
            $protocol = $_SERVER['HTTP_X_FORWARDED_PROTO'];
                      Severity: Minor
                      Found in GpWebPay/Settings.php - About 1 hr to fix

                        Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function __construct(
        SettingsInterface $settings,
        DigestSignerInterface $digestSigner,
        string $operation,
        int $orderNumber,
                        Severity: Minor
                        Found in GpWebPay/CardPayResponse.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function getCurrentRequestUrl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private function getCurrentRequestUrl(): string
    {
        $protocol = 'http';
        if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO'])) {
            $protocol = $_SERVER['HTTP_X_FORWARDED_PROTO'];
                        Severity: Minor
                        Found in GpWebPay/Settings.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language