Sign upLogin

jasonhillier/challenge

View on GitHub
Star

Showing 9 of 9 total issues

Function ChallengeInitializer has 258 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function ChallengeInitializer(pOptions)
{
    var libSuperTest = null;
    var _BaseJsonPath = argv.jsonPath || path.dirname(module.parent.filename) + '/';
    //Configure test runner, include a Rest client
Severity: Major
Found in source/Challenge.js - About 1 day to fix

    Function ChallengeInitializer has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
    Open

    function ChallengeInitializer(pOptions)
{
    var libSuperTest = null;
    var _BaseJsonPath = argv.jsonPath || path.dirname(module.parent.filename) + '/';
    //Configure test runner, include a Rest client
    Severity: Minor
    Found in source/Challenge.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function cases has 210 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            cases: function(pOptions)
        {
            var tmpAllCaseData = pOptions;

            if (pOptions.constructor !== Array)
    Severity: Major
    Found in source/Challenge.js - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      case 'PUT': //Update
                                    tmpRequest = libSuperTest
                                        .put(tmpOptions.url)
                                        .send(postBody);
                                    tmpfPrevalidator = function(pError, pResponse, pCase, fNext)
      Severity: Major
      Found in source/Challenge.js and 1 other location - About 6 hrs to fix
      source/Challenge.js on lines 217..237

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 156.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      case 'POST': //Create
                                    tmpRequest = libSuperTest
                                        .post(tmpOptions.url)
                                        .send(postBody);
                                    tmpfPrevalidator = function(pError, pResponse, pCase, fNext)
      Severity: Major
      Found in source/Challenge.js and 1 other location - About 6 hrs to fix
      source/Challenge.js on lines 196..216

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 156.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function testApi has 116 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      testApi: function(pName, pOptions, fValidation)
                {
                    return testDefinition.test(pName, function(pCase, fDone)
                        {
                            var tmpOptions = (typeof(pOptions) === 'function') ? pOptions(pCase) : pOptions;
      Severity: Major
      Found in source/Challenge.js - About 4 hrs to fix

        File Challenge.js has 272 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /**
* The Challenge Module
*
* @author Jason Hillier <jason@paviasystems.com>
* @class Challenge
        Severity: Minor
        Found in source/Challenge.js - About 2 hrs to fix

          Function test has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                          test: function(pName, fTest)
                {
                    for (var i=0; i<tmpAllCaseData.length; i++)
                    {
                        //keep test case data contextualized with the test function definition
          Severity: Minor
          Found in source/Challenge.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                        if (tmpAllCaseData[x])
                            {
                                tmpAllCaseData[x][join.name] = tmpJoinCases[x];
                            }
                            else
            Severity: Major
            Found in source/Challenge.js - About 45 mins to fix
              Severity
              Category
              Status
              Source
              Language