jasonrobertfox/tictactoe

View on GitHub

Showing 126 of 126 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          return this.delay(function () {
            return el
              .animate(end_css, this.settings.animationSpeed, 'linear', function () {
                this.locked = false;
                el.css(css).trigger('closed');
Severity: Major
Found in lib/assets/javascripts/foundation/foundation.reveal.js and 1 other location - About 3 hrs to fix
lib/assets/javascripts/foundation/foundation.reveal.js on lines 290..297

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File foundation.section.js has 322 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*jslint unparam: true, browser: true, indent: 2 */

;
(function($, window, document) {
  'use strict';
Severity: Minor
Found in lib/assets/javascripts/foundation/foundation.section.js - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          if (arguments.length > 0 && arguments[0] instanceof $) {
            el = arguments[0];
          } else if(this.settings.$target && !/body/i.test(this.settings.$target.selector)){
            el = this.settings.$target;
          }  else {
    Severity: Major
    Found in lib/assets/javascripts/foundation/foundation.joyride.js and 1 other location - About 3 hrs to fix
    lib/assets/javascripts/foundation/foundation.joyride.js on lines 580..586

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          if (arguments.length > 0 && arguments[0] instanceof $) {
            el = arguments[0];
          } else if(this.settings.$target && !/body/i.test(this.settings.$target.selector)){
            el = this.settings.$target;
          }  else {
    Severity: Major
    Found in lib/assets/javascripts/foundation/foundation.joyride.js and 1 other location - About 3 hrs to fix
    lib/assets/javascripts/foundation/foundation.joyride.js on lines 646..652

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File foundation.topbar.js has 292 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*jslint unparam: true, browser: true, indent: 2 */
    
    ;(function ($, window, document, undefined) {
      'use strict';
    
    
    Severity: Minor
    Found in lib/assets/javascripts/foundation/foundation.topbar.js - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                    if ($associatedElement.attr('type') === 'checkbox') {
                      e.preventDefault();
                      $customCheckbox = $(this).find('span.custom.checkbox');
                      //the checkbox might be outside after the label or inside of another element
                      if ($customCheckbox.length === 0) {
      Severity: Major
      Found in lib/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 2 hrs to fix
      lib/assets/javascripts/foundation/foundation.forms.js on lines 89..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                    } else if ($associatedElement.attr('type') === 'radio') {
                      e.preventDefault();
                      $customRadio = $(this).find('span.custom.radio');
                      //the radio might be outside after the label or inside of another element
                      if ($customRadio.length === 0) {
      Severity: Major
      Found in lib/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 2 hrs to fix
      lib/assets/javascripts/foundation/foundation.forms.js on lines 81..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File foundation.reveal.js has 285 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*jslint unparam: true, browser: true, indent: 2 */
      
      ;(function ($, window, document, undefined) {
        'use strict';
      
      
      Severity: Minor
      Found in lib/assets/javascripts/foundation/foundation.reveal.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        Board.prototype.clearHumanHover = function(element) {
          dom_space = getSpaceById(element[0].id);
          if (enabled === true && dom_space.prop('title') === '') {
            dom_space.removeClass('hover').removeClass(humanPlayer.iconClass);
          }
        Severity: Major
        Found in lib/assets/javascripts/Board.js and 1 other location - About 2 hrs to fix
        lib/assets/javascripts/Board.js on lines 62..67

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        Board.prototype.registerHumanHover = function(element) {
          dom_space = getSpaceById(element[0].id);
          if (enabled === true && dom_space.prop('title') === '') {
            dom_space.addClass('hover').addClass(humanPlayer.iconClass);
          }
        Severity: Major
        Found in lib/assets/javascripts/Board.js and 1 other location - About 2 hrs to fix
        lib/assets/javascripts/Board.js on lines 69..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function show has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            show : function (init) {
              var $timer = null;
        
              // are we paused?
              if (this.settings.$li === undefined
        Severity: Major
        Found in lib/assets/javascripts/foundation/foundation.joyride.js - About 2 hrs to fix

          Function events has 68 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              events : function () {
                var self = this;
                $(this.scope).on('arrival.fndtn.magellan', '[data-magellan-arrival]', function (e) {
                  var $destination = $(this),
                      $expedition = $destination.closest('[data-magellan-expedition]'),
          Severity: Major
          Found in lib/assets/javascripts/foundation/foundation.magellan.js - About 2 hrs to fix

            File foundation.placeholder.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /* 
             * The MIT License
             *
             * Copyright (c) 2012 James Allardice
             *
            Severity: Minor
            Found in lib/assets/javascripts/foundation/foundation.placeholder.js - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      } else if (classes && classes.indexOf('tip-right') > -1) {
                        objPos(tip, (target.offset().top + (this.outerHeight(target) / 2) - nubHeight*2.5), 'auto', 'auto', (target.offset().left + this.outerWidth(target) + nubHeight), width)
                          .removeClass('tip-override');
                      }
              Severity: Major
              Found in lib/assets/javascripts/foundation/foundation.tooltips.js and 1 other location - About 2 hrs to fix
              lib/assets/javascripts/foundation/foundation.tooltips.js on lines 156..162

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 86.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      } else if (classes && classes.indexOf('tip-left') > -1) {
                        objPos(tip, (target.offset().top + (this.outerHeight(target) / 2) - nubHeight*2.5), 'auto', 'auto', (target.offset().left - this.outerWidth(tip) - nubHeight), width)
                          .removeClass('tip-override');
                      } else if (classes && classes.indexOf('tip-right') > -1) {
                        objPos(tip, (target.offset().top + (this.outerHeight(target) / 2) - nubHeight*2.5), 'auto', 'auto', (target.offset().left + this.outerWidth(target) + nubHeight), width)
              Severity: Major
              Found in lib/assets/javascripts/foundation/foundation.tooltips.js and 1 other location - About 2 hrs to fix
              lib/assets/javascripts/foundation/foundation.tooltips.js on lines 159..162

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 86.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function append_custom_select has 62 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  append_custom_select: function (idx, sel) {
                      var self = Foundation.libs.forms,
                          $this = $(sel),
                          $customSelect = $this.next('div.custom.dropdown'),
                          $customList = $customSelect.find('ul'),
              Severity: Major
              Found in lib/assets/javascripts/foundation/foundation.forms.js - About 2 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    this.prev = function(current, prev, callback) {
                      prev.css({'margin':'0%', 'opacity':'0.01'});
                      prev.animate({'opacity':'1'}, duration, 'linear', function() {
                        current.css('margin', '100%');
                        callback();
                Severity: Major
                Found in lib/assets/javascripts/foundation/foundation.orbit.js and 1 other location - About 2 hrs to fix
                lib/assets/javascripts/foundation/foundation.orbit.js on lines 352..358

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    this.next = function(current, next, callback) {
                      next.css({'margin':'0%', 'opacity':'0.01'});
                      next.animate({'opacity':'1'}, duration, 'linear', function() {
                        current.css('margin', '100%');
                        callback();
                Severity: Major
                Found in lib/assets/javascripts/foundation/foundation.orbit.js and 1 other location - About 2 hrs to fix
                lib/assets/javascripts/foundation/foundation.orbit.js on lines 360..366

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if ( typeof data.is_scrolling === 'undefined') {
                            data.is_scrolling = !!( data.is_scrolling || Math.abs(data.delta_x) < Math.abs(e.touches[0].pageY - data.start_page_y) );
                          }
                Severity: Major
                Found in lib/assets/javascripts/foundation/foundation.orbit.js and 1 other location - About 2 hrs to fix
                lib/assets/javascripts/foundation/foundation.clearing.js on lines 140..142

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if ( typeof data.is_scrolling === 'undefined') {
                            data.is_scrolling = !!( data.is_scrolling || Math.abs(data.delta_x) < Math.abs(e.touches[0].pageY - data.start_page_y) );
                          }
                Severity: Major
                Found in lib/assets/javascripts/foundation/foundation.clearing.js and 1 other location - About 2 hrs to fix
                lib/assets/javascripts/foundation/foundation.orbit.js on lines 237..239

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language