Sign upLogin

jasonsnider/tinker-mvc

View on GitHub
Star
core/Tinker/src/Mvc/Interfaces/Router.php

Summary

Maintainability
A
0 mins
Test Coverage

The method getPlugin has a boolean flag argument $studlyCaps, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getPlugin($studlyCaps = false);
Severity: Minor
Found in core/Tinker/src/Mvc/Interfaces/Router.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getController has a boolean flag argument $studlyCaps, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getController($studlyCaps = false);
Severity: Minor
Found in core/Tinker/src/Mvc/Interfaces/Router.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status