Sign upLogin

jasonsnider/tinker-mvc

View on GitHub
Star
core/Tinker/src/Mvc/View.php

Summary

Maintainability
A
1 hr
Test Coverage

Function setViewPath has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function setViewPath()
    {
        $plugin = $this->Router->getPlugin(true);
        $controller = $this->Router->getController();
        $action = $this->Router->getAction();
Severity: Minor
Found in core/Tinker/src/Mvc/View.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method setViewPath uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                //If the literal path does not resolve, check against the include
                //paths
                $iPaths = explode(PATH_SEPARATOR, get_include_path());
                foreach ($iPaths as $path) {
Severity: Minor
Found in core/Tinker/src/Mvc/View.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using Tinker\Mvc\count() function in for loops.
Open

        for ($i = 0; $i < count($paths["{$plugin}\\"]); $i++) {
            $check = $paths["{$plugin}\\"][$i] . 'View' . DS . $controller . DS . $action . '.php';

            if (is_file($check)) {
                $file = $check;
Severity: Minor
Found in core/Tinker/src/Mvc/View.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if (is_file($check)) {
                $file = $check;
            } else {
                //If the literal path does not resolve, check against the include
                //paths
Severity: Minor
Found in core/Tinker/src/Mvc/View.php and 2 other locations - About 40 mins to fix
core/Tinker/src/Mvc/Router.php on lines 146..157
core/Tinker/src/Mvc/Theme.php on lines 165..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status