Sign upLogin

jaumard/ngx-dashboard

View on GitHub
Star
src/components/dashboard/dashboard.component.ts

Summary

Maintainability
F
3 days
Test Coverage

File dashboard.component.ts has 457 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  AfterViewInit,
  Component,
  ComponentFactoryResolver,
  ComponentRef,
Severity: Minor
Found in src/components/dashboard/dashboard.component.ts - About 7 hrs to fix

    DashboardComponent has 33 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
  selector: 'dashboard',
  template: '<div #target><ng-content></ng-content></div>',
  host: {
    '(window:resize)': '_onResize($event)',
    Severity: Minor
    Found in src/components/dashboard/dashboard.component.ts - About 4 hrs to fix

      Function _positionWidget has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

        private _positionWidget(lines: number[], items: ComponentRef<WidgetComponent>[], index: number, column: number, row: number): void {
    if (!items[index]) {
      let remainingHeight = 0;
      for (let i = 0; i < lines.length; i++) {
        if (remainingHeight < lines[i]) {
      Severity: Minor
      Found in src/components/dashboard/dashboard.component.ts - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _positionWidget has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private _positionWidget(lines: number[], items: ComponentRef<WidgetComponent>[], index: number, column: number, row: number): void {
    if (!items[index]) {
      let remainingHeight = 0;
      for (let i = 0; i < lines.length; i++) {
        if (remainingHeight < lines[i]) {
      Severity: Minor
      Found in src/components/dashboard/dashboard.component.ts - About 2 hrs to fix

        Function _onMouseMove has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          private _onMouseMove(e: any): boolean {
    if (this._isDragging) {
      //scroll while drag
      if (this._isTouchEvent(e))
        e = e.touches.length > 0 ? e.touches[0] : e.changedTouches[0];
        Severity: Minor
        Found in src/components/dashboard/dashboard.component.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _onMouseMove has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private _onMouseMove(e: any): boolean {
    if (this._isDragging) {
      //scroll while drag
      if (this._isTouchEvent(e))
        e = e.touches.length > 0 ? e.touches[0] : e.changedTouches[0];
        Severity: Minor
        Found in src/components/dashboard/dashboard.component.ts - About 1 hr to fix

          Function _onMouseUp has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            private _onMouseUp(e: any): boolean {
    if (this._isDragging) {
      this._isDragging = false;
      this._isScrolling = false;
      if (this._currentElement) {
          Severity: Minor
          Found in src/components/dashboard/dashboard.component.ts - About 1 hr to fix

            Function _onMouseUp has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              private _onMouseUp(e: any): boolean {
    if (this._isDragging) {
      this._isDragging = false;
      this._isScrolling = false;
      if (this._currentElement) {
            Severity: Minor
            Found in src/components/dashboard/dashboard.component.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                return 0;
            Severity: Major
            Found in src/components/dashboard/dashboard.component.ts - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (( widget1.instance.offset.left + ( widget1.instance.width / 2 ) ) > ( widget2.instance.offset.left + ( widget2.instance.width / 2 ) )) {
      return +1;
    }
              Severity: Major
              Found in src/components/dashboard/dashboard.component.ts and 1 other location - About 1 hr to fix
              src/components/dashboard/dashboard.component.ts on lines 514..516

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (( widget2.instance.offset.left + ( widget2.instance.width / 2 ) ) > ( widget1.instance.offset.left + ( widget1.instance.width / 2 ) )) {
      return -1;
    }
              Severity: Major
              Found in src/components/dashboard/dashboard.component.ts and 1 other location - About 1 hr to fix
              src/components/dashboard/dashboard.component.ts on lines 511..513

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (widget1.instance.offset.top > widget2.instance.offset.top + widget2.instance.height / 2) {
      return +1;
    }
              Severity: Major
              Found in src/components/dashboard/dashboard.component.ts and 1 other location - About 1 hr to fix
              src/components/dashboard/dashboard.component.ts on lines 508..510

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (widget2.instance.offset.top > widget1.instance.offset.top + widget1.instance.height / 2) {
      return -1;
    }
              Severity: Major
              Found in src/components/dashboard/dashboard.component.ts and 1 other location - About 1 hr to fix
              src/components/dashboard/dashboard.component.ts on lines 505..507

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                public enableDrag(): void {
    this.dragEnable = true;
    this._renderer.removeClass(this._ngEl.nativeElement, 'disabled');
  }
              Severity: Minor
              Found in src/components/dashboard/dashboard.component.ts and 1 other location - About 35 mins to fix
              src/components/dashboard/dashboard.component.ts on lines 152..155

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                public disableDrag(): void {
    this.dragEnable = false;
    this._renderer.addClass(this._ngEl.nativeElement, 'disabled');
  }
              Severity: Minor
              Found in src/components/dashboard/dashboard.component.ts and 1 other location - About 35 mins to fix
              src/components/dashboard/dashboard.component.ts on lines 147..150

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status