Sign upLogin

jbenden/windows

View on GitHub
Star

Showing 13 of 13 total issues

Function newPathImpl has a Cognitive Complexity of 117 (exceeds 20 allowed). Consider refactoring.
Open

func newPathImpl(path string) *PathImpl {
    _path := &PathImpl{}

    runeArrayLen := utf8.RuneCountInString(path)
    runeArray := make([]rune, runeArrayLen)
Severity: Minor
Found in path.go - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function newPathImpl has 112 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func newPathImpl(path string) *PathImpl {
    _path := &PathImpl{}

    runeArrayLen := utf8.RuneCountInString(path)
    runeArray := make([]rune, runeArrayLen)
Severity: Major
Found in path.go - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                Context("when an absolute path is forced to absolute", func() {
                BeforeEach(func() {
                    subject = windows.Path("\\msys64").MakeAbsolute()
                })
    Severity: Major
    Found in path_test.go and 1 other location - About 2 hrs to fix
    path_test.go on lines 543..564

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 227.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                Context("when an absolute path is forced to absolute", func() {
                BeforeEach(func() {
                    subject = windows.Path("\\msys64").MakeAbsolute()
                })
    Severity: Major
    Found in path_test.go and 1 other location - About 2 hrs to fix
    path_test.go on lines 447..468

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 227.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                Context("when a file is forced to be an absolute path", func() {
                BeforeEach(func() {
                    subject = windows.Path("path_test.go").MakeAbsolute()
                })
    Severity: Major
    Found in path_test.go and 1 other location - About 2 hrs to fix
    path_test.go on lines 470..490

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                Context("when a file is forced to be an absolute path", func() {
                BeforeEach(func() {
                    subject = windows.Path("path_test.go").MakeAbsolute()
                })
    Severity: Major
    Found in path_test.go and 1 other location - About 2 hrs to fix
    path_test.go on lines 566..586

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func SystemCodePageToUtf8(text string) (s string, e error) {
    e = ErrInvalidEncoding
    str := C.CString(text)
    defer C.free(unsafe.Pointer(str)) // #nosec
    Severity: Major
    Found in acp.go and 1 other location - About 1 hr to fix
    acp.go on lines 116..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 130.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func Utf8ToSystemCodePage(text string) (s string, e error) {
    e = ErrInvalidEncoding
    str := C.CString(text)
    defer C.free(unsafe.Pointer(str)) // #nosec
    Severity: Major
    Found in acp.go and 1 other location - About 1 hr to fix
    acp.go on lines 101..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 130.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid deeply nested control flow statements.
    Open

                        goto loopStart
    Severity: Major
    Found in path.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      goto loopStart
      Severity: Major
      Found in path.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            switch curSubState {
                    case substateUnicode:
                        if node == "UNC" {
                            // UNICODE UNC path, but UNC share
                            curIdx++
        Severity: Major
        Found in path.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              goto loopStart
          Severity: Major
          Found in path.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if curIdx+2 < runeArrayLen && runeArray[curIdx+2] == '\\' {
                        _path.absolute = true
                    }
            Severity: Major
            Found in path.go - About 45 mins to fix
              Severity
              Category
              Status
              Source
              Language