Showing 368 of 368 total issues
Class has too many lines. [168/100] Open
class Specification
MULTIPLE_POSTPONES_ERROR_MESSAGE =
"Only one indefinite `wait' block at the same time is allowed!"
attr_reader :description- Read upRead up
- Exclude checks
This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Class has too many lines. [122/100] Open
class Context
include ContextHelper::Matchers
include ContextHelper::Should
include ContextHelper::Expectation
include ContextHelper::MemoizedHelpers- Read upRead up
- Exclude checks
This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Method execute_block has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def execute_block
yield
rescue Object => e
@exception_occurred = true
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Class Context has 21 methods (exceeds 20 allowed). Consider refactoring. Open
class Context
include ContextHelper::Matchers
include ContextHelper::Should
include ContextHelper::Expectation
include ContextHelper::MemoizedHelpersAssignment Branch Condition size for execute_block is too high. [29.26/25] Open
def execute_block
yield
rescue Object => e
@exception_occurred = true
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Assignment Branch Condition size for proxy_existing_method is too high. [29.88/25] Open
def proxy_existing_method(method, options = {}, &_block)
method_alias = "__old_#{method}".to_sym
meta_eval { module_eval { alias_method method_alias, method } }
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Perceived complexity for execute_block is too high. [10/7] Open
def execute_block
yield
rescue Object => e
@exception_occurred = true
- Read upRead up
- Exclude checks
This cop tries to produce a complexity score that's a measure of the
complexity the reader experiences when looking at a method. For that
reason it considers when nodes as something that doesn't add as much
complexity as an if or a &&. Except if it's one of those special
case/when constructs where there's no expression after case. Then
the cop treats it as an if/elsif/elsif... and lets all the when
nodes count. In contrast to the CyclomaticComplexity cop, this cop
considers else nodes as adding complexity.
Example:
def my_method # 1
if cond # 1
case var # 2 (0.8 + 4 * 0.2, rounded)
when 1 then func_one
when 2 then func_two
when 3 then func_three
when 4..10 then func_other
end
else # 1
do_something until a && b # 2
end # ===
end # 7 complexity pointsPerceived complexity for satisfy is too high. [8/7] Open
def satisfy(*args, &_block)
if args.size == 1 && String === args.first
description = args.shift
else
description = ''- Read upRead up
- Exclude checks
This cop tries to produce a complexity score that's a measure of the
complexity the reader experiences when looking at a method. For that
reason it considers when nodes as something that doesn't add as much
complexity as an if or a &&. Except if it's one of those special
case/when constructs where there's no expression after case. Then
the cop treats it as an if/elsif/elsif... and lets all the when
nodes count. In contrast to the CyclomaticComplexity cop, this cop
considers else nodes as adding complexity.
Example:
def my_method # 1
if cond # 1
case var # 2 (0.8 + 4 * 0.2, rounded)
when 1 then func_one
when 2 then func_two
when 3 then func_three
when 4..10 then func_other
end
else # 1
do_something until a && b # 2
end # ===
end # 7 complexity pointsCyclomatic complexity for execute_block is too high. [7/6] Open
def execute_block
yield
rescue Object => e
@exception_occurred = true
- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Perceived complexity for proxy_existing_method is too high. [8/7] Open
def proxy_existing_method(method, options = {}, &_block)
method_alias = "__old_#{method}".to_sym
meta_eval { module_eval { alias_method method_alias, method } }
- Read upRead up
- Exclude checks
This cop tries to produce a complexity score that's a measure of the
complexity the reader experiences when looking at a method. For that
reason it considers when nodes as something that doesn't add as much
complexity as an if or a &&. Except if it's one of those special
case/when constructs where there's no expression after case. Then
the cop treats it as an if/elsif/elsif... and lets all the when
nodes count. In contrast to the CyclomaticComplexity cop, this cop
considers else nodes as adding complexity.
Example:
def my_method # 1
if cond # 1
case var # 2 (0.8 + 4 * 0.2, rounded)
when 1 then func_one
when 2 then func_two
when 3 then func_three
when 4..10 then func_other
end
else # 1
do_something until a && b # 2
end # ===
end # 7 complexity pointsMethod proxy_existing_method has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def proxy_existing_method(method, options = {}, &_block)
method_alias = "__old_#{method}".to_sym
meta_eval { module_eval { alias_method method_alias, method } }
Method proxy_existing_method has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def proxy_existing_method(method, options = {}, &_block)
method_alias = "__old_#{method}".to_sym
meta_eval { module_eval { alias_method method_alias, method } }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method satisfy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def satisfy(*args, &_block)
if args.size == 1 && String === args.first
description = args.shift
else
description = ''- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method message_for_raise_error has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.message_for_raise_error(negated, show_class, error_class, show_message, error_message, rescued_exception)Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(context, description, block, before_filters, after_filters)Method message_for_have_items has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.message_for_have_items(negated, subject, expected_number_of_items, actual_number_of_items, key_type_name)Method mock! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def mock!(method, options = {}, &block)
MotionSpec::Mocks.add([self, method])
behavior =
if block_given?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run_postponed_block has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def run_postponed_block(block)
# If an exception occurred, we definitely don't need execute any more blocks
execute_block(&block) unless @exception_occurred
@postponed_blocks_count -= 1
unless postponed?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.run(arg = nil)
unless respond_to?(:handle_specification_begin)
extend(Outputs[ENV['output']] || DEFAULT_OUTPUT_MODULE)
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Add an empty line after magic comments. Open
class AppDelegate- Read upRead up
- Exclude checks
Checks for a newline after the final magic comment.
Example:
# good
# frozen_string_literal: true
# Some documentation for Person
class Person
# Some code
end
# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
# Some code
end