Sign upLogin

jbox-web/gitolite

View on GitHub
Star

Showing 7 of 7 total issues

Method process_config has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def process_config(config)
      context = [] # will store our context for permissions or config declarations

      # Read each line of our config
      File.open(config, 'r').each do |l|
Severity: Minor
Found in lib/gitolite/config.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_config has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def process_config(config)
      context = [] # will store our context for permissions or config declarations

      # Read each line of our config
      File.open(config, 'r').each do |l|
Severity: Major
Found in lib/gitolite/config.rb - About 2 hrs to fix

    Method save has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def save(commit_message = DEFAULT_COMMIT_MSG, options = {})

      # Process config file (if loaded, i.e. may be modified)
      if @config
        new_conf = @config.to_file(@conf_dir_path)
    Severity: Minor
    Found in lib/gitolite/gitolite_admin.rb - About 1 hr to fix

      Method bootstrap has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def bootstrap(path, options = {})
        if self.is_gitolite_admin_repo?(path)
          if options[:overwrite]
            FileUtils.rm_rf(File.join(path, '*'))
          else
      Severity: Minor
      Found in lib/gitolite/gitolite_admin.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def save(commit_message = DEFAULT_COMMIT_MSG, options = {})

      # Process config file (if loaded, i.e. may be modified)
      if @config
        new_conf = @config.to_file(@conf_dir_path)
      Severity: Minor
      Found in lib/gitolite/gitolite_admin.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(type, blob, email, owner = nil, location = '')
      Severity: Minor
      Found in lib/gitolite/ssh_key.rb - About 35 mins to fix

        Method to_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def to_file(path='.', filename=@filename)
      raise ArgumentError, 'Path contains a filename or does not exist' unless File.directory?(path)

      new_conf = File.join(path, filename)
      File.open(new_conf, 'w') do |f|
        Severity: Minor
        Found in lib/gitolite/config.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language